zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-08-03 00:12:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove long-dead LogsExportCursor and PersistedRangeLong

Browse source 
LogsExportCursor was only used by ExportLogsTaskServlet, which we removed a long time ago.  It's just dead code.  The PersistedRangeLong type was only written for use by LogsExportCursor, and since it hasn't picked up new users in 3+ years I don't think we need to keep it around.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=169264994
This commit is contained in:
nickfelt 2017-09-19 10:51:28 -07:00 • committed by jianglai
parent 0994ce76c7
commit 67116c5fa1
8 changed files with 0 additions and 307 deletions
Download patch file Download diff file Expand all files Collapse all files

1
javatests/google/registry/export/backup_kinds.txt
View file

@ -12,7 +12,6 @@ HistoryEntry
HostResource
KmsSecret
KmsSecretRevision
LogsExportCursor
LrpTokenEntity
Modification
OneTime

91
javatests/google/registry/model/common/PersistedRangeLongTest.java
View file

@ -1,91 +0,0 @@
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package google.registry.model.common;
import static com.google.common.truth.Truth.assertThat;
import com.google.common.collect.Range;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** Unit tests for {@link PersistedRangeLong}. */
@RunWith(JUnit4.class)
public class PersistedRangeLongTest {
private void doConversionTest(Range<Long> range) {
assertThat(PersistedRangeLong.create(range).asRange()).isEqualTo(range);
}
@Test
public void all() {
doConversionTest(Range.<Long>all());
}
@Test
public void lessThan() {
doConversionTest(Range.<Long>lessThan(10L));
}
@Test
public void atMost() {
doConversionTest(Range.<Long>atMost(10L));
}
@Test
public void greaterThan() {
doConversionTest(Range.<Long>greaterThan(10L));
}
@Test
public void atLeast() {
doConversionTest(Range.<Long>atLeast(10L));
}
@Test
public void open() {
doConversionTest(Range.<Long>open(5L, 10L));
}
@Test
public void closed() {
doConversionTest(Range.<Long>closed(5L, 10L));
}
@Test
public void openClosed() {
doConversionTest(Range.<Long>openClosed(5L, 10L));
}
@Test
public void closedOpen() {
doConversionTest(Range.<Long>closedOpen(5L, 10L));
}
@Test
public void singleton() {
doConversionTest(Range.<Long>singleton(5L));
}
@Test
public void openClosedEmpty() {
doConversionTest(Range.<Long>openClosed(5L, 5L));
}
@Test
public void closedOpenEmpty() {
doConversionTest(Range.<Long>closedOpen(5L, 5L));
}
}

64
javatests/google/registry/model/export/LogsExportCursorTest.java
View file

@ -1,64 +0,0 @@
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package google.registry.model.export;
import static com.google.common.truth.Truth.assertThat;
import static google.registry.model.ofy.ObjectifyService.ofy;
import static google.registry.testing.DatastoreHelper.persistResource;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Range;
import google.registry.model.EntityTestCase;
import google.registry.model.common.PersistedRangeLong;
import org.junit.Before;
import org.junit.Test;
/** Unit tests for {@link LogsExportCursor}. */
public class LogsExportCursorTest extends EntityTestCase {
LogsExportCursor logsExportCursor;
@Before
public void setUp() throws Exception {
logsExportCursor = new LogsExportCursor.Builder()
.setExportedRanges(ImmutableSet.of(
PersistedRangeLong.create(Range.<Long>all()),
PersistedRangeLong.create(Range.<Long>lessThan(10L)),
PersistedRangeLong.create(Range.<Long>atMost(10L)),
PersistedRangeLong.create(Range.<Long>greaterThan(10L)),
PersistedRangeLong.create(Range.<Long>atLeast(10L)),
PersistedRangeLong.create(Range.<Long>open(5L, 10L)),
PersistedRangeLong.create(Range.<Long>closed(5L, 10L)),
PersistedRangeLong.create(Range.<Long>openClosed(5L, 10L)),
PersistedRangeLong.create(Range.<Long>closedOpen(5L, 10L))))
.setFilesPendingImport(ImmutableList.of(
"gs://foo/bar",
"gs://foo/baz",
"gs://foo/bash"))
.build();
persistResource(logsExportCursor);
}
@Test
public void testPersistence() throws Exception {
assertThat(ofy().load().entity(logsExportCursor).now()).isEqualTo(logsExportCursor);
}
@Test
public void testIndexing() throws Exception {
verifyIndexing(logsExportCursor);
}
}

12
javatests/google/registry/model/schema.txt
View file

@ -117,12 +117,6 @@ class google.registry.model.common.GaeUserIdConverter {
@Id long id;
com.google.appengine.api.users.User user;
}
class google.registry.model.common.PersistedRangeLong {
com.google.common.collect.BoundType lowerBoundType;
com.google.common.collect.BoundType upperBoundType;
java.lang.Long lowerBound;
java.lang.Long upperBound;
}
class google.registry.model.common.TimeOfYear {
java.lang.String timeString;
}
@ -371,12 +365,6 @@ class google.registry.model.eppcommon.Trid {
java.lang.String clientTransactionId;
java.lang.String serverTransactionId;
}
class google.registry.model.export.LogsExportCursor {
@Id long id;
@Parent com.googlecode.objectify.Key<google.registry.model.common.EntityGroupRoot> parent;
java.util.List<java.lang.String> filesPendingImport;
java.util.Set<google.registry.model.common.PersistedRangeLong> exportedRanges;
}
class google.registry.model.host.HostResource {
@Id java.lang.String repoId;
com.google.common.collect.ImmutableSortedMap<org.joda.time.DateTime, com.googlecode.objectify.Key<google.registry.model.ofy.CommitLogManifest>> revisions;