zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-20 17:56:08 +02:00
Code Issues Projects Releases Packages Wiki Activity

Move tests to use TestDataHelper for reading resources

Browse source 
TestDataHelper is build exactly to prevent direct reads of resources. It caches
the resources and makes sure they are in the correct directory.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=191785004
This commit is contained in:
guyben 2018-04-05 13:01:59 -07:00 • committed by Ben McIlwain
parent e5c0a85b3b
commit 6699915132
16 changed files with 70 additions and 78 deletions
Download patch file Download diff file Expand all files Collapse all files

19
javatests/google/registry/tools/CreatePremiumListCommandTest.java
View file

@ -17,7 +17,7 @@ package google.registry.tools;
import static com.google.common.truth.Truth.assertThat;
import static google.registry.request.JsonResponse.JSON_SAFETY_PREFIX;
import static google.registry.testing.JUnitBackports.assertThrows;
import static google.registry.util.ResourceUtils.readResourceUtf8;
import static google.registry.testing.TestDataHelper.loadFile;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyMapOf;
import static org.mockito.Matchers.eq;
@ -48,11 +48,10 @@ public class CreatePremiumListCommandTest<C extends CreatePremiumListCommand>
@Before
public void init() throws Exception {
command.setConnection(connection);
premiumTermsPath = writeToNamedTmpFile(
"example_premium_terms.csv",
readResourceUtf8(
CreatePremiumListCommandTest.class,
"testdata/example_premium_terms.csv"));
premiumTermsPath =
writeToNamedTmpFile(
"example_premium_terms.csv",
loadFile(CreatePremiumListCommandTest.class, "example_premium_terms.csv"));
servletPath = "/_dr/admin/createPremiumList";
when(connection.send(
eq(CreatePremiumListAction.PATH),
@ -108,10 +107,10 @@ public class CreatePremiumListCommandTest<C extends CreatePremiumListCommand>
@Test
public void testRun_invalidInputData() throws Exception {
premiumTermsPath = writeToNamedTmpFile(
"tmp_file2",
readResourceUtf8(
CreatePremiumListCommandTest.class, "testdata/example_invalid_premium_terms.csv"));
premiumTermsPath =
writeToNamedTmpFile(
"tmp_file2",
loadFile(CreatePremiumListCommandTest.class, "example_invalid_premium_terms.csv"));
IllegalArgumentException thrown =
assertThrows(
IllegalArgumentException.class,