Update ListDomainsAction to SQL (#1036)

This commit is contained in:
gbrodman 2021-03-29 12:54:45 -04:00 committed by GitHub
parent a4e078305d
commit 65e468f2bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 61 additions and 41 deletions

View file

@ -19,13 +19,15 @@ import static google.registry.testing.DatabaseHelper.createTlds;
import static google.registry.testing.DatabaseHelper.persistActiveDomain;
import com.google.common.collect.ImmutableSet;
import google.registry.testing.DualDatabaseTest;
import google.registry.testing.FakeClock;
import google.registry.testing.TestOfyAndSql;
import java.util.Optional;
import org.joda.time.DateTime;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
/** Unit tests for {@link ListDomainsAction}. */
@DualDatabaseTest
class ListDomainsActionTest extends ListActionTestCase {
private ListDomainsAction action;
@ -38,7 +40,7 @@ class ListDomainsActionTest extends ListActionTestCase {
action.limit = Integer.MAX_VALUE;
}
@Test
@TestOfyAndSql
void testRun_invalidRequest_missingTlds() {
action.tlds = ImmutableSet.of();
testRunError(
@ -49,7 +51,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^Must specify TLDs to query$");
}
@Test
@TestOfyAndSql
void testRun_invalidRequest_invalidTld() {
action.tlds = ImmutableSet.of("%%%badtld%%%");
testRunError(
@ -60,13 +62,13 @@ class ListDomainsActionTest extends ListActionTestCase {
"^TLDs do not exist: %%%badtld%%%$");
}
@Test
@TestOfyAndSql
void testRun_noParameters() {
action.tlds = ImmutableSet.of("foo");
testRunSuccess(action, null, null, null);
}
@Test
@TestOfyAndSql
void testRun_twoLinesWithIdOnly() {
action.tlds = ImmutableSet.of("foo");
createTlds("bar", "sim");
@ -84,7 +86,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^example2.foo$");
}
@Test
@TestOfyAndSql
void testRun_multipleTlds() {
action.tlds = ImmutableSet.of("bar", "foo");
createTlds("bar", "sim");
@ -102,7 +104,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^example2.foo$");
}
@Test
@TestOfyAndSql
void testRun_moreTldsThanMaxNumSubqueries() {
ListDomainsAction.maxNumSubqueries = 2;
createTlds("baa", "bab", "bac", "bad");
@ -125,7 +127,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^domain3.bac$");
}
@Test
@TestOfyAndSql
void testRun_twoLinesWithIdOnlyNoHeader() {
action.tlds = ImmutableSet.of("foo");
persistActiveDomain("example1.foo", DateTime.parse("2010-03-04T16:00:00Z"));
@ -139,7 +141,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^example2.foo$");
}
@Test
@TestOfyAndSql
void testRun_twoLinesWithIdOnlyExplicitHeader() {
action.tlds = ImmutableSet.of("foo");
persistActiveDomain("example1.foo", DateTime.parse("2010-03-04T16:00:00Z"));
@ -155,7 +157,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^example2.foo\\s*$");
}
@Test
@TestOfyAndSql
void testRun_twoLinesWithRepoId() {
action.tlds = ImmutableSet.of("foo");
persistActiveDomain("example1.foo", DateTime.parse("2010-03-04T16:00:00Z"));
@ -171,7 +173,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^example3.foo\\s+4-FOO\\s*$");
}
@Test
@TestOfyAndSql
void testRun_twoLinesWithRepoIdNoHeader() {
action.tlds = ImmutableSet.of("foo");
persistActiveDomain("example1.foo", DateTime.parse("2010-03-04T16:00:00Z"));
@ -185,7 +187,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^example3.foo 4-FOO$");
}
@Test
@TestOfyAndSql
void testRun_twoLinesWithRepoIdExplicitHeader() {
action.tlds = ImmutableSet.of("foo");
persistActiveDomain("example1.foo", DateTime.parse("2010-03-04T16:00:00Z"));
@ -201,7 +203,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^example3.foo\\s+4-FOO\\s*$");
}
@Test
@TestOfyAndSql
void testRun_twoLinesWithWildcard() {
action.tlds = ImmutableSet.of("foo");
persistActiveDomain("example1.foo", DateTime.parse("2010-03-04T16:00:00Z"));
@ -217,7 +219,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^example3.foo\\s+.*4-FOO");
}
@Test
@TestOfyAndSql
void testRun_twoLinesWithWildcardAndAnotherField() {
action.tlds = ImmutableSet.of("foo");
persistActiveDomain("example1.foo", DateTime.parse("2010-03-04T16:00:00Z"));
@ -233,7 +235,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^example3.foo\\s+.*4-FOO");
}
@Test
@TestOfyAndSql
void testRun_withBadField_returnsError() {
action.tlds = ImmutableSet.of("foo");
persistActiveDomain("example2.foo");
@ -246,7 +248,7 @@ class ListDomainsActionTest extends ListActionTestCase {
"^Field 'badfield' not found - recognized fields are:");
}
@Test
@TestOfyAndSql
void testRun_limitFiltersOutOldestDomains() {
createTlds("bar", "baz");
action.tlds = ImmutableSet.of("foo", "bar");