zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-30 17:24:03 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove outdated comment in RdeUploadActionTest

Browse source 
I think this comment was meant to be the justification for not using "localhost" (aka a hostname) in the URLs, because jsch would mangle it.  However, we already cut over to using "localhost" in [] to avoid a dependency on IPv4, and it's been fine.  So this comment no longer makes sense.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158063880
This commit is contained in:
nickfelt 2017-06-05 14:40:02 -07:00 • committed by Ben McIlwain
parent b98380254f
commit 60022ae315
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
javatests/google/registry/rde/RdeUploadActionTest.java
View file

@ -278,8 +278,6 @@ public class RdeUploadActionTest {
@Test @Test
public void testRunWithLock_succeedsOnThirdTry() throws Exception { public void testRunWithLock_succeedsOnThirdTry() throws Exception {
// XXX: For any port other than 22, JSch will reformat the hostname IPv6 style which causes
// known host matching to fail.
int port = sftpd.serve("user", "password", folder.getRoot()); int port = sftpd.serve("user", "password", folder.getRoot());
URI uploadUrl = URI.create(String.format("sftp://user:password@localhost:%d/", port)); URI uploadUrl = URI.create(String.format("sftp://user:password@localhost:%d/", port));
DateTime stagingCursor = DateTime.parse("2010-10-18TZ"); DateTime stagingCursor = DateTime.parse("2010-10-18TZ");