zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-22 10:46:10 +02:00
Code Issues Projects Releases Packages Wiki Activity

Drop should publish field from ReservedList entity (#2369)

Browse source 
* Remove the shouldPublish field from the reservedLIst entity

* Add generated schema file
This commit is contained in:
sarahcaseybot 2024-03-14 18:04:18 -04:00 • committed by GitHub
parent 6e57d93507
commit 5f9c7de516
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/src/main/java/google/registry/model/tld/label/ReservedList.java
View file

@ -71,10 +71,6 @@ public final class ReservedList
*/ */
@Insignificant @Transient Map<String, ReservedListEntry> reservedListMap; @Insignificant @Transient Map<String, ReservedListEntry> reservedListMap;
// TODO(b/321053918): Remove this field once the column is nullable
@Column(nullable = true)
boolean shouldPublish = true;
@PreRemove @PreRemove
void preRemove() { void preRemove() {
tm().query("DELETE FROM ReservedEntry WHERE revision_id = :revisionId") tm().query("DELETE FROM ReservedEntry WHERE revision_id = :revisionId")

2
core/src/test/java/google/registry/tools/server/ListReservedListsActionTest.java
View file

@ -69,7 +69,7 @@ class ListReservedListsActionTest extends ListActionTestCase {
Optional.of("*"), Optional.of("*"),
Optional.empty(), Optional.empty(),
Optional.empty(), Optional.empty(),
"^name\\s+.*shouldPublish.*", "^name\\s+.*",
"^-+\\s+-+", "^-+\\s+-+",
"^xn--q9jyb4c-private\\s+.*", "^xn--q9jyb4c-private\\s+.*",
"^xn--q9jyb4c-published\\s+.*"); "^xn--q9jyb4c-published\\s+.*");

1
db/src/main/resources/sql/schema/db-schema.sql.generated
View file

@ -693,7 +693,6 @@
revision_id bigserial not null, revision_id bigserial not null,
creation_timestamp timestamptz, creation_timestamp timestamptz,
name text not null, name text not null,
should_publish boolean,
primary key (revision_id) primary key (revision_id)
); );

2
gradle.properties
View file

@ -1,4 +1,4 @@
# This file defines properties used by the Gradle build. It must be kept in # This file defines properties used by the gradle build. It must be kept in
# sync with config/nom_build.py. # sync with config/nom_build.py.
# #
# To regenerate, run ./nom_build --generate-gradle-properties # To regenerate, run ./nom_build --generate-gradle-properties