zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 16:37:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add metric related unit tests to EppControllerTest and FlowRunnerTest

Browse source 
This is one of a series of CLs which will refactor EppMetrics into a value type
and Metrics into a stateless class which will have an export(EppMetrics requestDetails)
method to export EPP metrics in a stateless way. Once EppMetrics is a value
type, I will create a new StackdriverEppMetrics that will also accept the value
type via an incrementRequests(EppMetrics requestDetails), allowing us to
monitor EPP via BigQuery and Stackdriver with minimum code duplication.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=131973288
This commit is contained in:
shikhman 2016-09-01 11:44:56 -07:00 • committed by Ben McIlwain
parent 5098b03af4
commit 5ee78c505d
2 changed files with 110 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

30
javatests/google/registry/flows/FlowRunnerTest.java
View file

@ -19,6 +19,8 @@ import static com.google.common.truth.Truth.assertThat;
import static google.registry.testing.TestDataHelper.loadFileWithSubstitutions;
import static java.nio.charset.StandardCharsets.UTF_8;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import com.google.appengine.api.users.User;
import com.google.common.base.Joiner;
@ -32,6 +34,7 @@ import com.google.common.testing.TestLogHandler;
import google.registry.model.eppcommon.Trid;
import google.registry.model.eppinput.EppInput;
import google.registry.model.eppoutput.EppOutput;
import google.registry.model.eppoutput.EppResponse;
import google.registry.monitoring.whitebox.EppMetrics;
import google.registry.testing.AppEngineRule;
import google.registry.testing.FakeClock;
@ -42,6 +45,7 @@ import java.util.List;
import java.util.Map;
import java.util.logging.LogRecord;
import java.util.logging.Logger;
import org.joda.time.DateTime;
import org.json.simple.JSONValue;
import org.junit.Before;
import org.junit.Rule;
@ -64,6 +68,12 @@ public class FlowRunnerTest extends ShardableTestCase {
public void before() {
Logger.getLogger(FlowRunner.class.getCanonicalName()).addHandler(handler);
final EppOutput eppOutput = mock(EppOutput.class);
EppResponse eppResponse = mock(EppResponse.class);
when(eppResponse.getCreatedRepoId()).thenReturn("foo");
when(eppResponse.getExecutionTime()).thenReturn(new DateTime(1337));
when(eppOutput.getResponse()).thenReturn(eppResponse);
flowRunner.clientId = "TheRegistrar";
flowRunner.clock = new FakeClock();
flowRunner.credentials = new PasswordOnlyTransportCredentials();
@ -74,8 +84,9 @@ public class FlowRunnerTest extends ShardableTestCase {
new Flow() {
@Override
protected EppOutput run() {
return null;
}});
return eppOutput;
}
});
flowRunner.inputXmlBytes = "<xml/>".getBytes(UTF_8);
flowRunner.isDryRun = false;
flowRunner.isSuperuser = false;
@ -98,6 +109,21 @@ public class FlowRunnerTest extends ShardableTestCase {
"xmlBytes", "PHhtbC8+");
}
@Test
public void testRun_notIsTransactional_callsMetricIncrementAttempts() throws Exception {
flowRunner.run();
verify(flowRunner.metrics).incrementAttempts();
}
@Test
public void testRun_isTransactional_callsMetricIncrementAttempts() throws Exception {
flowRunner.isTransactional = true;
flowRunner.run();
verify(flowRunner.metrics).incrementAttempts();
}
@Test
public void testRun_reportingLogStatement_noClientId() throws Exception {
flowRunner.clientId = null;