diff --git a/core/src/main/java/google/registry/tools/CreateOrUpdateRegistrarCommand.java b/core/src/main/java/google/registry/tools/CreateOrUpdateRegistrarCommand.java index b81206460..987b1bb54 100644 --- a/core/src/main/java/google/registry/tools/CreateOrUpdateRegistrarCommand.java +++ b/core/src/main/java/google/registry/tools/CreateOrUpdateRegistrarCommand.java @@ -292,8 +292,8 @@ abstract class CreateOrUpdateRegistrarCommand extends MutatingCommand { } if (!isNullOrEmpty(email)) { builder.setEmailAddress(email); - } else if (!isNullOrEmpty( - icannReferralEmail)) { // fall back to ICANN referral email if present + } else if (!isNullOrEmpty(icannReferralEmail) && oldRegistrar == null) { + // On creates, fall back to ICANN referral email (if present). builder.setEmailAddress(icannReferralEmail); } if (url != null) { diff --git a/core/src/test/java/google/registry/tools/UpdateRegistrarCommandTest.java b/core/src/test/java/google/registry/tools/UpdateRegistrarCommandTest.java index 07cc2c845..ec24f22aa 100644 --- a/core/src/test/java/google/registry/tools/UpdateRegistrarCommandTest.java +++ b/core/src/test/java/google/registry/tools/UpdateRegistrarCommandTest.java @@ -637,10 +637,12 @@ class UpdateRegistrarCommandTest extends CommandTestCase @Test void testSuccess_setIcannEmail() throws Exception { - runCommand("--icann_referral_email=foo@bar.test", "--force", "TheRegistrar"); Registrar registrar = loadRegistrar("TheRegistrar"); - assertThat(registrar.getIcannReferralEmail()).isEqualTo("foo@bar.test"); - assertThat(registrar.getEmailAddress()).isEqualTo("foo@bar.test"); + assertThat(registrar.getEmailAddress()).isEqualTo("the.registrar@example.com"); + runCommand("--icann_referral_email=foo@bar.test", "--force", "TheRegistrar"); + Registrar updatedRegistrar = loadRegistrar("TheRegistrar"); + assertThat(updatedRegistrar.getIcannReferralEmail()).isEqualTo("foo@bar.test"); + assertThat(updatedRegistrar.getEmailAddress()).isEqualTo("the.registrar@example.com"); } @Test