Upgrade Nomulus to latest Closure Rules

Significant technical debt has been eliminated. The latest best
practices are also now adopted for dealing with runfiles and dealing
with files across repositories.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=140762937
This commit is contained in:
jart 2016-12-01 12:33:53 -08:00 committed by Ben McIlwain
parent 79a72387ee
commit 59f4984083
28 changed files with 193 additions and 361 deletions

View file

@ -11,9 +11,7 @@ filegroup(
name = "runfiles",
srcs = glob(["assets/**"]) + [
"brain_bin.js",
"brain_bin_map.js",
"registrar_bin.js",
"registrar_bin_map.js",
"//java/google/registry/ui/css:registrar_bin.css",
"//java/google/registry/ui/html:html_files",
],
@ -22,20 +20,13 @@ filegroup(
filegroup(
name = "runfiles_debug",
srcs = [
"brain_bin.js.map",
"deps.js",
"registrar_bin.js.map",
"registrar_dbg.js",
"//java/google/registry/ui/css:css_files",
"//java/google/registry/ui/css:registrar_dbg.css",
"//java/google/registry/ui/js:js_files",
"//java/google/registry/ui/js/registrar:js_files",
"//java/google/registry/ui/soy:js_files",
"//java/google/registry/ui/soy/registrar:js_files",
"//javascript/closure:js_files_recursive",
"//javascript/template/soy:soy_usegoog_js_files",
"@closure_library//:js_files",
":brain_bin",
":deps",
":registrar_bin",
":registrar_dbg",
"//java/google/registry/ui/css:registrar_dbg",
],
data = [":deps"],
)
zip_file(
@ -43,10 +34,10 @@ zip_file(
srcs = [":runfiles"],
out = "ui.war",
mappings = {
"java/google/registry/ui/assets": "assets",
"java/google/registry/ui/css": "assets/css",
"java/google/registry/ui/html": "",
"java/google/registry/ui": "assets/js",
"domain_registry/java/google/registry/ui/assets": "assets",
"domain_registry/java/google/registry/ui/css": "assets/css",
"domain_registry/java/google/registry/ui/html": "",
"domain_registry/java/google/registry/ui": "assets/js",
},
)
@ -54,12 +45,12 @@ zip_file(
name = "war_debug",
srcs = [":runfiles_debug"],
out = "ui_debug.war",
data = [":runfiles_debug"],
mappings = {
"java/google/registry/ui/deps.js": "assets/sources/deps.js",
"java/google/registry/ui/brain_bin.js.map": "assets/js/brain_bin.js.map",
"java/google/registry/ui/registrar_bin.js.map": "assets/js/registrar_bin.js.map",
"java/google/registry/ui/registrar_dbg.js": "assets/js/registrar_dbg.js",
"java/google/registry/ui/css/registrar_dbg.css": "assets/css/registrar_dbg.css",
"domain_registry/java/google/registry/ui/brain_bin.js.map": "assets/js/brain_bin.js.map",
"domain_registry/java/google/registry/ui/registrar_bin.js.map": "assets/js/registrar_bin.js.map",
"domain_registry/java/google/registry/ui/registrar_dbg.js": "assets/js/registrar_dbg.js",
"domain_registry/java/google/registry/ui/css/registrar_dbg.css": "assets/css/registrar_dbg.css",
"": "assets/sources",
},
deps = [":war"],
@ -80,10 +71,7 @@ java_library(
closure_js_deps(
name = "deps",
deps = [
"//java/google/registry/ui/js",
"//java/google/registry/ui/js/registrar",
],
deps = ["//java/google/registry/ui/js/registrar"],
)
################################################################################
@ -98,22 +86,13 @@ closure_js_binary(
name = "registrar_bin",
css = "//java/google/registry/ui/css:registrar_bin",
entry_points = ["goog:registry.registrar.main"],
output_wrapper = "%output%//# sourceMappingURL=registrar_bin.js.map",
deps = [
"//java/google/registry/ui/externs",
"//java/google/registry/ui/js/registrar",
],
)
# The webserver should provide this to trusted admin users, rather than
# registrar_bin.js. This is what makes debugging in production possible.
genrule(
name = "registrar_mapped",
srcs = ["registrar_bin.js"],
outs = ["registrar_bin_map.js"],
cmd = "cat $(location registrar_bin.js) >$@ && " +
"echo '//# sourceMappingURL=registrar_bin.js.map' >>$@",
)
# This target creates a compiled JavaScript file where symbols are renamed to
# include dollar signs. This is useful for testing, because you can still read
# the source code, but it'll fail if your code is incorrect with regard to
@ -137,16 +116,9 @@ closure_js_binary(
closure_js_binary(
name = "brain_bin",
entry_points = ["goog:registry.registrar.BrainFrame.main"],
output_wrapper = "%output%//# sourceMappingURL=brain_bin.js.map",
deps = [
"//java/google/registry/ui/externs",
"//java/google/registry/ui/js/registrar",
],
)
genrule(
name = "brain_mapped",
srcs = ["brain_bin.js"],
outs = ["brain_bin_map.js"],
cmd = "cat $(location brain_bin.js) >$@ && " +
"echo '//# sourceMappingURL=brain_bin.js.map' >>$@",
)