zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-30 22:46:26 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add metrics measuring all request processing times

Browse source 
The cardinality of this new metric is:
buckets - 16
path + method - around 100 (the number of Actions we have)
authLevel - at most 3
success - 2

Total: 16*100*3*2 = 9,600

This is still low, especially for the value it could give in understanding our system (graphs of all endpoints, how often are they called, how long they take, how often do they fail)

Instead of "success true/false", we might want to give the actual status code. This can be a bit annoying because HttpServletResponse doesn't have a getStatus.

But it's possible, and worth considering.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=219312400
This commit is contained in:
guyben 2018-10-30 09:23:55 -07:00 • committed by jianglai
parent a45d3d3bc7
commit 57f06258d3
5 changed files with 103 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
java/google/registry/request/BUILD
View file

@ -21,6 +21,7 @@ java_library(
"@com_google_flogger",
"@com_google_flogger_system_backend",
"@com_google_guava",
"@com_google_monitoring_client_metrics",
"@com_googlecode_json_simple",
"@javax_inject",
"@javax_servlet_api",