zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 16:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Don't verify existence of autorenew poll messages

Browse source 
There are several situations in which it is a valid system state for
Keys to PollMessages on Domains to point to entities that don't exist,
chief amongst them when a domain has been soft-deleted.  We also can't
simply null this out when soft-deleting domains, because there may be
an un-acked recurrence meaning it can't be deleted.

Given this, it doesn't make sense to check for entity existence here,
as it is not a system invariant and cannot easily be made to be so.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=122300368
This commit is contained in:
mcilwain 2016-05-13 15:12:00 -07:00 • committed by Justine Tunney
parent 030d6b92ab
commit 56c8bb0f2a
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
java/google/registry/monitoring/whitebox/VerifyEntityIntegrityAction.java
View file

@ -274,7 +274,6 @@ public class VerifyEntityIntegrityAction implements Runnable {
DomainResource domain = (DomainResource) domainBase; DomainResource domain = (DomainResource) domainBase;
verifyExistence(key, domain.getApplication()); verifyExistence(key, domain.getApplication());
verifyExistence(key, domain.getAutorenewBillingEvent()); verifyExistence(key, domain.getAutorenewBillingEvent());
verifyExistence(key, domain.getAutorenewPollMessage());
for (GracePeriod gracePeriod : domain.getGracePeriods()) { for (GracePeriod gracePeriod : domain.getGracePeriods()) {
verifyExistence(key, gracePeriod.getOneTimeBillingEvent()); verifyExistence(key, gracePeriod.getOneTimeBillingEvent());
verifyExistence(key, gracePeriod.getRecurringBillingEvent()); verifyExistence(key, gracePeriod.getRecurringBillingEvent());