zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-04-29 19:47:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove not null constraint request_log_id column (#1917)

Browse source
This commit is contained in:
Pavlo Tkach 2023-01-23 09:37:20 -05:00 • committed by GitHub
parent 4250a9d165
commit 5210ac0419
7 changed files with 27 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/src/main/java/google/registry/model/server/Lock.java
View file

@ -88,8 +88,7 @@ public class Lock extends ImmutableObject implements Serializable {
* <p>See {@link RequestStatusCheckerImpl#getLogId} for details about how it's created in
* practice.
*/
@Column(nullable = false)
String requestLogId;
@Column String requestLogId;
/** When the lock can be considered implicitly released. */
@Column(nullable = false)

6
db/src/main/resources/sql/er_diagram/brief_er_diagram.html
View file

@ -261,11 +261,11 @@ td.section {
</tr>
<tr>
<td class="property_name">generated on</td>
<td class="property_value">2023-01-20 18:26:00.403125</td>
<td class="property_value">2023-01-20 19:50:48.623695</td>
</tr>
<tr>
<td class="property_name">last flyway file</td>
<td id="lastFlywayFile" class="property_value">V133__add_pull_queue_replace_columns.sql</td>
<td id="lastFlywayFile" class="property_value">V134__drop_not_null_request_id_lock_table.sql</td>
</tr>
</tbody>
</table>
@ -284,7 +284,7 @@ td.section {
generated on
</text>
<text text-anchor="start" x="3835.5" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">
2023-01-20 18:26:00.403125
2023-01-20 19:50:48.623695
</text>
<polygon fill="none" stroke="#888888" points="3748,-4 3748,-44 4013,-44 4013,-4 3748,-4" /> <!-- allocationtoken_a08ccbef -->
<g id="node1" class="node">

10
db/src/main/resources/sql/er_diagram/full_er_diagram.html
View file

@ -261,11 +261,11 @@ td.section {
</tr>
<tr>
<td class="property_name">generated on</td>
<td class="property_value">2023-01-20 18:25:58.806689</td>
<td class="property_value">2023-01-20 19:50:45.218406</td>
</tr>
<tr>
<td class="property_name">last flyway file</td>
<td id="lastFlywayFile" class="property_value">V133__add_pull_queue_replace_columns.sql</td>
<td id="lastFlywayFile" class="property_value">V134__drop_not_null_request_id_lock_table.sql</td>
</tr>
</tbody>
</table>
@ -284,7 +284,7 @@ td.section {
generated on
</text>
<text text-anchor="start" x="4519.5" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">
2023-01-20 18:25:58.806689
2023-01-20 19:50:45.218406
</text>
<polygon fill="none" stroke="#888888" points="4432,-4 4432,-44 4697,-44 4697,-4 4432,-4" /> <!-- allocationtoken_a08ccbef -->
<g id="node1" class="node">
@ -5672,7 +5672,7 @@ td.section {
<text text-anchor="start" x="4456" y="-5413.3" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="4464" y="-5413.3" font-family="Helvetica,sans-Serif" font-size="14.00">
text not null
text
</text>
<polygon fill="none" stroke="#888888" points="4347.5,-5406.5 4347.5,-5522.5 4588.5,-5522.5 4588.5,-5406.5 4347.5,-5406.5" />
</g> <!-- packagepromotion_56aa33 -->
@ -11795,7 +11795,7 @@ td.section {
<tr>
<td class="spacer"></td>
<td class="minwidth">request_log_id</td>
<td class="minwidth">text not null</td>
<td class="minwidth">text</td>
</tr>
<tr>
<td colspan="3"></td>

1
db/src/main/resources/sql/flyway.txt
View file

@ -131,3 +131,4 @@ V130__add_login_email_column_to_registrarpoc.sql
V131__add_default_promo_tokens_to_registry.sql
V132__drop_gae_user_id_from_registrar_poc.sql
V133__add_pull_queue_replace_columns.sql
V134__drop_not_null_request_id_lock_table.sql

15
db/src/main/resources/sql/flyway/V134__drop_not_null_request_id_lock_table.sql Normal file
View file

@ -0,0 +1,15 @@
-- Copyright 2022 The Nomulus Authors. All Rights Reserved.
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.
ALTER TABLE "Lock" ALTER COLUMN request_log_id DROP NOT NULL;

2
db/src/main/resources/sql/schema/db-schema.sql.generated
View file

@ -488,7 +488,7 @@
scope text not null,
acquired_time timestamptz not null,
expiration_time timestamptz not null,
request_log_id text not null,
request_log_id text,
primary key (resource_name, scope)
);

2
db/src/main/resources/sql/schema/nomulus.golden.sql
View file

@ -645,7 +645,7 @@ CREATE TABLE public."Lock" (
scope text NOT NULL,
acquired_time timestamp with time zone NOT NULL,
expiration_time timestamp with time zone NOT NULL,
request_log_id text NOT NULL
request_log_id text
);