zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-16 17:37:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Export Weimin as author of commits to GitHub

Browse source 
Also adds Guy to list of CONTRIBUTORS and removes Xooglers (who definitely won't be contributing more code).

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=202476218
This commit is contained in:
mcilwain 2018-06-28 07:34:45 -07:00 • committed by jianglai
parent bb1b4bc0d4
commit 513f2ad72e
5 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
CONTRIBUTORS
View file

@ -30,3 +30,5 @@ Jordyn Buchanan <jordyn@google.com>
Wolfgang Meyers <wolfgang@donuts.co> Wolfgang Meyers <wolfgang@donuts.co>
Hans Ridder <hans.ridder@gmail.com> Hans Ridder <hans.ridder@gmail.com>
Justin Graham <justin.af.graham@gmail.com> Justin Graham <justin.af.graham@gmail.com>
Guy Bensky <guyben@google.com>
Weimin Yu <weiminyu@google.com>

1
java/google/registry/dns/writer/clouddns/CloudDnsWriterModule.java
View file

@ -59,6 +59,7 @@ public abstract class CloudDnsWriterModule {
@IntoMap @IntoMap
@StringKey(CloudDnsWriter.NAME) @StringKey(CloudDnsWriter.NAME)
abstract DnsWriter provideWriter(CloudDnsWriter writer); abstract DnsWriter provideWriter(CloudDnsWriter writer);
@Provides @Provides
@IntoSet @IntoSet
@Named("dnsWriterNames") @Named("dnsWriterNames")

6
java/google/registry/tools/CreateOrUpdatePremiumListCommand.java
View file

@ -110,12 +110,12 @@ abstract class CreateOrUpdatePremiumListCommand extends ConfirmingCommand
return extractServerResponse(response); return extractServerResponse(response);
} }
// TODO(tjb): refactor this behavior into a better general-purpose // TODO(user): refactor this behavior into a better general-purpose
// response validation that can be re-used across the new client/server commands. // response validation that can be re-used across the new client/server commands.
String extractServerResponse(String response) { String extractServerResponse(String response) {
Map<String, Object> responseMap = toMap(JSONValue.parse(stripJsonPrefix(response))); Map<String, Object> responseMap = toMap(JSONValue.parse(stripJsonPrefix(response)));
// TODO(tjb): consider using jart's FormField Framework. // TODO(user): consider using jart's FormField Framework.
// See: j/c/g/d/r/ui/server/RegistrarFormFields.java // See: j/c/g/d/r/ui/server/RegistrarFormFields.java
String status = (String) responseMap.get("status"); String status = (String) responseMap.get("status");
Verify.verify(!status.equals("error"), "Server error: %s", responseMap.get("error")); Verify.verify(!status.equals("error"), "Server error: %s", responseMap.get("error"));
@ -128,7 +128,7 @@ abstract class CreateOrUpdatePremiumListCommand extends ConfirmingCommand
return (Map<String, Object>) obj; return (Map<String, Object>) obj;
} }
// TODO(tjb): figure out better place to put this method to make it re-usable // TODO(user): figure out better place to put this method to make it re-usable
static String stripJsonPrefix(String json) { static String stripJsonPrefix(String json) {
Verify.verify(json.startsWith(JSON_SAFETY_PREFIX)); Verify.verify(json.startsWith(JSON_SAFETY_PREFIX));
return json.substring(JSON_SAFETY_PREFIX.length()); return json.substring(JSON_SAFETY_PREFIX.length());

1
java/google/registry/ui/server/registrar/BUILD
View file

@ -26,7 +26,6 @@ java_library(
"//java/google/registry/ui/soy/registrar:soy_java_wrappers", "//java/google/registry/ui/soy/registrar:soy_java_wrappers",
"//java/google/registry/util", "//java/google/registry/util",
"//third_party/objectify:objectify-v4_1", "//third_party/objectify:objectify-v4_1",
"@com_braintreepayments_gateway_braintree_java",
"@com_google_appengine_api_1_0_sdk", "@com_google_appengine_api_1_0_sdk",
"@com_google_code_findbugs_jsr305", "@com_google_code_findbugs_jsr305",
"@com_google_dagger", "@com_google_dagger",

1
javatests/google/registry/ui/server/registrar/BUILD
View file

@ -25,7 +25,6 @@ java_library(
"//javatests/google/registry/security", "//javatests/google/registry/security",
"//javatests/google/registry/testing", "//javatests/google/registry/testing",
"//third_party/objectify:objectify-v4_1", "//third_party/objectify:objectify-v4_1",
"@com_braintreepayments_gateway_braintree_java",
"@com_google_appengine_api_1_0_sdk", "@com_google_appengine_api_1_0_sdk",
"@com_google_flogger", "@com_google_flogger",
"@com_google_flogger_system_backend", "@com_google_flogger_system_backend",