zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add assertTldsExist(Iterable<String>) to check multiple TLDs at once

Browse source 
This is better than calling assertTldExists() inside a for loop because you can throw a single exception reporting all bad TLDs at once rather than only getting as far as the first failure.  And then it's also a one-liner instead of 3 lines.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=152412876
This commit is contained in:
nickfelt 2017-04-06 12:28:15 -07:00 • committed by Ben McIlwain
parent 783033c261
commit 5081d780dc
8 changed files with 31 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

6
java/google/registry/tools/GenerateZoneFilesCommand.java
View file

@ -14,7 +14,7 @@
package google.registry.tools;
import static google.registry.model.registry.Registries.assertTldExists;
import static google.registry.model.registry.Registries.assertTldsExist;
import static org.joda.time.DateTimeZone.UTC;
import static org.joda.time.Duration.standardMinutes;
@ -54,9 +54,7 @@ final class GenerateZoneFilesCommand implements ServerSideCommand {
@Override
public void run() throws IOException {
for (String tld : mainParameters) {
assertTldExists(tld);
}
assertTldsExist(mainParameters);
ImmutableMap<String, Object> params = ImmutableMap.of(
"tlds", mainParameters,
"exportTime", exportDate.toString());