zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-29 07:43:37 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove MapUserTypeTest from Integration TestSuite (#449)

Browse source 
* Remove MapUserTypeTest from Integration TestSuite
This commit is contained in:
Weimin Yu 2020-01-17 14:14:14 -05:00 • committed by GitHub
parent 90b5855474
commit 4fec3c6a58
2 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
core/src/test/java/google/registry/persistence/MapUserTypeTest.java
View file

@ -21,7 +21,7 @@ import static org.junit.Assert.assertThrows;
import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableMap;
import google.registry.model.ImmutableObject; import google.registry.model.ImmutableObject;
import google.registry.model.transaction.JpaTestRules; import google.registry.model.transaction.JpaTestRules;
import google.registry.model.transaction.JpaTestRules.JpaIntegrationTestRule; import google.registry.model.transaction.JpaTestRules.JpaUnitTestRule;
import java.util.Map; import java.util.Map;
import javax.persistence.Entity; import javax.persistence.Entity;
import javax.persistence.Id; import javax.persistence.Id;
@ -36,11 +36,14 @@ import org.junit.runners.JUnit4;
@RunWith(JUnit4.class) @RunWith(JUnit4.class)
public class MapUserTypeTest { public class MapUserTypeTest {
// Note that JpaIntegrationTestRule is used here as the hstore extension is installed // Reusing production script sql/flyway/V14__load_extension_for_hstore.sql, which loads the
// when nomulus.golden.sql is executed as the init script. // hstore extension but nothing else.
@Rule @Rule
public final JpaIntegrationTestRule jpaRule = public final JpaUnitTestRule jpaRule =
new JpaTestRules.Builder().withEntityClass(TestEntity.class).buildIntegrationTestRule(); new JpaTestRules.Builder()
.withInitScript("sql/flyway/V14__load_extension_for_hstore.sql")
.withEntityClass(TestEntity.class)
.buildUnitTestRule();
@Test @Test
public void roundTripConversion_returnsSameMap() { public void roundTripConversion_returnsSameMap() {

2
core/src/test/java/google/registry/schema/integration/SqlIntegrationTestSuite.java
View file

@ -16,7 +16,6 @@ package google.registry.schema.integration;
import google.registry.model.registry.RegistryLockDaoTest; import google.registry.model.registry.RegistryLockDaoTest;
import google.registry.model.transaction.JpaTestRules.JpaIntegrationTestRule; import google.registry.model.transaction.JpaTestRules.JpaIntegrationTestRule;
import google.registry.persistence.MapUserTypeTest;
import google.registry.schema.cursor.CursorDaoTest; import google.registry.schema.cursor.CursorDaoTest;
import google.registry.schema.tld.PremiumListDaoTest; import google.registry.schema.tld.PremiumListDaoTest;
import google.registry.schema.tld.PremiumListUtilsTest; import google.registry.schema.tld.PremiumListUtilsTest;
@ -46,7 +45,6 @@ import org.junit.runners.Suite.SuiteClasses;
CreateReservedListCommandTest.class, CreateReservedListCommandTest.class,
CursorDaoTest.class, CursorDaoTest.class,
CreatePremiumListActionTest.class, CreatePremiumListActionTest.class,
MapUserTypeTest.class,
PremiumListDaoTest.class, PremiumListDaoTest.class,
PremiumListUtilsTest.class, PremiumListUtilsTest.class,
RegistryLockDaoTest.class, RegistryLockDaoTest.class,