zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-01 00:33:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

Delete deprecated legacy SQL 'latest_snapshot' dataset

Browse source 
We've migrated everything over to using the standard SQL view now. The legacy
version is just causing confusion and costing us resources.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=201966352
This commit is contained in:
mcilwain 2018-06-25 09:31:25 -07:00 • committed by Ben McIlwain
parent aa11d5681f
commit 4cddbdacff
3 changed files with 17 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

16
javatests/google/registry/export/UpdateSnapshotViewActionTest.java
View file

@ -102,21 +102,18 @@ public class UpdateSnapshotViewActionTest {
InOrder factoryOrder = inOrder(bigqueryFactory);
// Check that the BigQuery factory was called in such a way that the dataset would be created
// if it didn't already exist.
factoryOrder.verify(bigqueryFactory).create("myproject", "latest_snapshot");
factoryOrder.verify(bigqueryFactory).create("myproject", "latest_datastore_export");
// Check that we updated both views
InOrder tableOrder = inOrder(bigqueryTables);
ArgumentCaptor<Table> tableArg = ArgumentCaptor.forClass(Table.class);
tableOrder.verify(bigqueryTables)
.update(eq("myproject"), eq("latest_snapshot"), eq("fookind"), tableArg.capture());
tableOrder.verify(bigqueryTables)
tableOrder
.verify(bigqueryTables)
.update(eq("myproject"), eq("latest_datastore_export"), eq("fookind"), tableArg.capture());
Iterable<String> actualQueries =
Iterables.transform(tableArg.getAllValues(), table -> table.getView().getQuery());
assertThat(actualQueries).containsExactly(
"#legacySQL\nSELECT * FROM [myproject:some_dataset.12345_fookind]",
"#standardSQL\nSELECT * FROM `myproject.some_dataset.12345_fookind`");
assertThat(actualQueries)
.containsExactly("#standardSQL\nSELECT * FROM `myproject.some_dataset.12345_fookind`");
}
@Test
@ -125,7 +122,10 @@ public class UpdateSnapshotViewActionTest {
.thenThrow(new IOException("I'm sorry Dave, I can't let you do that"));
InternalServerErrorException thrown =
assertThrows(InternalServerErrorException.class, action::run);
assertThat(thrown).hasMessageThat().contains("Could not update snapshot view for table");
assertThat(thrown)
.hasMessageThat()
.isEqualTo(
"Could not update snapshot view latest_datastore_export for table 12345_fookind");
assertThat(thrown).hasCauseThat().hasMessageThat().contains("I'm sorry Dave");
}
}