zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-08-05 01:11:50 +02:00
Code Issues Projects Releases Packages Wiki Activity

Upgrade the version of google/errorprone plug-in

Browse source 
This CL upgraded google/errorprone plug-in to 2.3.3 and resolved
some warnings detected from the plug-in.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=238047862
This commit is contained in:
shicong 2019-03-12 10:41:49 -07:00 • committed by Ben McIlwain
parent 058c12c343
commit 4b6ace920b
22 changed files with 119 additions and 105 deletions
Download patch file Download diff file Expand all files Collapse all files

9
javatests/google/registry/reporting/icann/IcannReportingStagingActionTest.java
View file

@ -149,14 +149,17 @@ public class IcannReportingStagingActionTest {
RuntimeException thrown = assertThrows(RuntimeException.class, action::run);
assertThat(thrown).hasCauseThat().isInstanceOf(BigqueryJobFailureException.class);
assertThat(thrown).hasMessageThat().isEqualTo("Staging action failed.");
assertThat(thrown).hasCauseThat().hasMessageThat().isEqualTo("Expected failure");
assertThat(thrown)
.hasCauseThat()
.hasMessageThat()
.isEqualTo("BigqueryJobFailureException: Expected failure");
verify(stager, times(3)).stageReports(yearMonth, subdir, ReportType.ACTIVITY);
verify(action.emailService)
.sendEmail(
EmailMessage.create(
"ICANN Monthly report staging summary [FAILURE]",
"Staging failed due to BigqueryJobFailureException: Expected failure,"
+ " check logs for more details.",
"Staging failed due to google.registry.bigquery.BigqueryJobFailureException: "
+ "BigqueryJobFailureException: Expected failure, check logs for more details.",
new InternetAddress("recipient@example.com"),
new InternetAddress("sender@example.com")));
// Assert no upload task enqueued

3
javatests/google/registry/testing/AppEngineRule.java
View file

@ -32,7 +32,6 @@ import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Sets;
import com.google.common.flogger.FluentLogger;
import com.google.common.io.Files;
import com.googlecode.objectify.ObjectifyFilter;
import google.registry.model.ofy.ObjectifyService;
@ -71,8 +70,6 @@ import org.junit.runners.model.Statement;
*/
public final class AppEngineRule extends ExternalResource {
private static final FluentLogger logger = FluentLogger.forEnclosingClass();
public static final String NEW_REGISTRAR_GAE_USER_ID = "666";
public static final String THE_REGISTRAR_GAE_USER_ID = "31337";