zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 00:47:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add a convenient method to DistributionMetricSubject

Browse source 
Currently to assert that a given Metric<Distribution> as a certain distribution for some labels, the caller needs to manually create an ImmutableDistribution and pass it to #hasValueForLabels method. With this change, an ImmutableSet of data points can be passed to #hasDataSetForLabels method.

Also switched to use expectThrow backport from JUnit 4.13.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=173544521
This commit is contained in:
jianglai 2017-10-26 09:01:26 -07:00
parent 4a9b8b918a
commit 4a5b9fc288
4 changed files with 135 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

142
javatests/google/registry/monitoring/metrics/contrib/DistributionMetricSubjectTest.java
View file

@ -15,9 +15,8 @@
package google.registry.monitoring.metrics.contrib;
import static com.google.common.truth.Truth.assertThat;
import static com.google.common.truth.Truth8.assertThat;
import static google.registry.monitoring.metrics.contrib.DistributionMetricSubject.assertThat;
import static org.junit.Assert.fail;
import static google.registry.testing.JUnitBackports.expectThrows;
import com.google.common.collect.ImmutableSet;
import google.registry.monitoring.metrics.EventMetric;
@ -54,17 +53,15 @@ public class DistributionMetricSubjectTest {
@Test
public void testWrongNumberOfLabels_fails() {
try {
assertThat(metric).hasAnyValueForLabels("Domestic");
fail("Expected assertion error");
} catch (AssertionError e) {
assertThat(e)
.hasMessageThat()
.isEqualTo(
"Not true that </test/event/sheep> has a value for labels <Domestic>."
+ " It has labeled values <[Bighorn:Blue =>"
+ " {[4.0..16.0)=1}, Domestic:Green => {[1.0..4.0)=1}]>");
}
AssertionError e =
expectThrows(
AssertionError.class, () -> assertThat(metric).hasAnyValueForLabels("Domestic"));
assertThat(e)
.hasMessageThat()
.isEqualTo(
"Not true that </test/event/sheep> has a value for labels <Domestic>."
+ " It has labeled values <[Bighorn:Blue =>"
+ " {[4.0..16.0)=1}, Domestic:Green => {[1.0..4.0)=1}]>");
}
@Test
@ -89,33 +86,104 @@ public class DistributionMetricSubjectTest {
@Test
public void testDoesNotHaveValueForLabels_failure() {
try {
assertThat(metric).doesNotHaveAnyValueForLabels("Domestic", "Green");
fail("Expected assertion error");
} catch (AssertionError e) {
assertThat(e)
.hasMessageThat()
.isEqualTo(
"Not true that </test/event/sheep> has no value for labels <Domestic:Green>."
+ " It has a value of <{[1.0..4.0)=1}>");
}
AssertionError e =
expectThrows(
AssertionError.class,
() -> assertThat(metric).doesNotHaveAnyValueForLabels("Domestic", "Green"));
assertThat(e)
.hasMessageThat()
.isEqualTo(
"Not true that </test/event/sheep> has no value for labels <Domestic:Green>."
+ " It has a value of <{[1.0..4.0)=1}>");
}
@Test
public void testUnexpectedValue_failure() {
try {
assertThat(metric)
.hasAnyValueForLabels("Domestic", "Green")
.and()
.hasNoOtherValues();
fail("Expected assertion error");
} catch (AssertionError e) {
assertThat(e)
.hasMessageThat()
.isEqualTo(
"Not true that </test/event/sheep> has <no other nondefault values>."
+ " It has labeled values <[Bighorn:Blue =>"
+ " {[4.0..16.0)=1}, Domestic:Green => {[1.0..4.0)=1}]>");
}
AssertionError e =
expectThrows(
AssertionError.class,
() ->
assertThat(metric)
.hasAnyValueForLabels("Domestic", "Green")
.and()
.hasNoOtherValues());
assertThat(e)
.hasMessageThat()
.isEqualTo(
"Not true that </test/event/sheep> has <no other nondefault values>."
+ " It has labeled values <[Bighorn:Blue =>"
+ " {[4.0..16.0)=1}, Domestic:Green => {[1.0..4.0)=1}]>");
}
@Test
public void testExpectedDataSet_success() {
metric.record(7.5, "Domestic", "Green");
assertThat(metric).hasDataSetForLabels(ImmutableSet.of(2.5, 7.5), "Domestic", "Green");
}
@Test
public void testExpectedDataSetsChained_success() {
metric.record(7.5, "Domestic", "Green");
assertThat(metric)
.hasDataSetForLabels(ImmutableSet.of(2.5, 7.5), "Domestic", "Green")
.and()
.hasDataSetForLabels(ImmutableSet.of(10), "Bighorn", "Blue")
.and()
.hasNoOtherValues();
}
@Test
public void testUnexpectedDataSet_failure() {
AssertionError e =
expectThrows(
AssertionError.class,
() ->
assertThat(metric)
.hasDataSetForLabels(ImmutableSet.of(2.5, 7.5), "Domestic", "Green"));
assertThat(e)
.hasMessageThat()
.isEqualTo(
"Not true that </test/event/sheep> has a value of"
+ " {[1.0..4.0)=1,[4.0..16.0)=1} for labels <Domestic:Green>."
+ " It has a value of <{[1.0..4.0)=1}>");
}
@Test
public void testNonExistentLabels_failure() {
AssertionError e =
expectThrows(
AssertionError.class,
() ->
assertThat(metric)
.hasDataSetForLabels(ImmutableSet.of(2.5, 7.5), "Domestic", "Blue"));
assertThat(e)
.hasMessageThat()
.isEqualTo(
"Not true that </test/event/sheep> has a value for labels <Domestic:Blue>."
+ " It has labeled values <[Bighorn:Blue => {[4.0..16.0)=1},"
+ " Domestic:Green => {[1.0..4.0)=1}]>");
}
@Test
public void testEmptyMetric_failure() {
EventMetric emptyMetric =
MetricRegistryImpl.getDefault()
.newEventMetric(
"/test/event/goat",
"Sheep Latency",
"sheeplatency",
LABEL_DESCRIPTORS,
EventMetric.DEFAULT_FITTER);
AssertionError e =
expectThrows(
AssertionError.class,
() ->
assertThat(emptyMetric)
.hasDataSetForLabels(ImmutableSet.of(2.5, 7.5), "Domestic", "Blue"));
assertThat(e)
.hasMessageThat()
.isEqualTo(
"Not true that </test/event/goat> has a distribution for labels <Domestic:Blue>."
+ " It has <no values>");
}
}