zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-30 14:36:28 +02:00
Code Issues Projects Releases Packages Wiki Activity

Rename "clientIdentifier" to "clientId" almost everywhere

Browse source 
It's best to be consistent and use the same thing everywhere.  "clientId" was
already used in more places and is shorter and no more ambiguous, so it's the
logical one to win out.

Note that this CL is almost solely a big Eclipse-assisted refactoring. There are
two places that I did not change clientIdentifier -- the actual entity field on
Registrar (though I did change all getters and setters), and the name of a
column on the exported registrar spreadsheet. Both would require data
migrations.

Also fixes a few minor nits discovered in touched files, including an incorrect
test in OfyFilterTest.java and some superfluous uses of String.format() when
calling checkArgument().

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=133956465
This commit is contained in:
mcilwain 2016-09-22 08:31:00 -07:00 • committed by Ben McIlwain
parent 0564bcdbc9
commit 4813ed392b
62 changed files with 208 additions and 200 deletions
Download patch file Download diff file Expand all files Collapse all files

22
javatests/google/registry/model/domain/TestExtraLogicManager.java
View file

@ -45,7 +45,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
@Override
public List<String> getExtensionFlags(
DomainResource domainResource, String clientIdentifier, DateTime asOfDate) {
DomainResource domainResource, String clientId, DateTime asOfDate) {
// Take the part before the period, split by dashes, and treat each part after the first as
// a flag.
List<String> components =
@ -55,7 +55,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
return components.subList(1, components.size());
}
BaseFee domainNameToFeeOrCredit(String domainName) {
BaseFee domainNameToFeeOrCredit(String domainName) {
// The second-level domain should be of the form "description-price", where description is the
// description string of the fee or credit, and price is the price (credit if negative, fee
// otherwise). To make sure this is a valid domain name, don't use any spaces, and limit prices
@ -79,7 +79,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
@Override
public BaseFee getCreateFeeOrCredit(
String domainName,
String clientIdentifier,
String clientId,
DateTime asOfDate,
int years,
EppInput eppInput) throws EppException {
@ -93,7 +93,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
@Override
public void performAdditionalDomainCreateLogic(
DomainResource domain,
String clientIdentifier,
String clientId,
DateTime asOfDate,
int years,
EppInput eppInput,
@ -113,7 +113,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
@Override
public void performAdditionalDomainDeleteLogic(
DomainResource domainResource,
String clientIdentifier,
String clientId,
DateTime asOfDate,
EppInput eppInput,
HistoryEntry historyEntry) throws EppException {
@ -124,7 +124,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
@Override
public BaseFee getRenewFeeOrCredit(
DomainResource domain,
String clientIdentifier,
String clientId,
DateTime asOfDate,
int years,
EppInput eppInput) throws EppException {
@ -138,7 +138,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
@Override
public void performAdditionalDomainRenewLogic(
DomainResource domainResource,
String clientIdentifier,
String clientId,
DateTime asOfDate,
int years,
EppInput eppInput,
@ -153,7 +153,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
@Override
public void performAdditionalDomainRestoreLogic(
DomainResource domainResource,
String clientIdentifier,
String clientId,
DateTime asOfDate,
EppInput eppInput,
HistoryEntry historyEntry) throws EppException {
@ -167,7 +167,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
@Override
public void performAdditionalDomainTransferLogic(
DomainResource domainResource,
String clientIdentifier,
String clientId,
DateTime asOfDate,
int years,
EppInput eppInput,
@ -188,7 +188,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
@Override
public BaseFee getUpdateFeeOrCredit(
DomainResource domain,
String clientIdentifier,
String clientId,
DateTime asOfDate,
EppInput eppInput) throws EppException {
return domainNameToFeeOrCredit(domain.getFullyQualifiedDomainName());
@ -201,7 +201,7 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic {
@Override
public void performAdditionalDomainUpdateLogic(
DomainResource domainResource,
String clientIdentifier,
String clientId,
DateTime asOfDate,
EppInput eppInput,
HistoryEntry historyEntry) throws EppException {