Remove columns for unused ofy key reconstitution (#1706)

* Remove columns for unused ofy key reconstitution

Remove the columns in Domain, DomainHistory, GracePeriod and
GracePeriodHistory that were only used for Ofy key reconstitution.

All uses of these were removed in #1660.

* Add forgotten flyway file.

db/src/main/resources/sql/flyway.txt

@@ -117,3 +117,4 @@ V116__add_renewal_column_to_allocation_token.sql
 V117__add_billing_recurrence_last_expansion_column.sql
 V118__drop_billing_identifier_column_from_registrar.sql
 V119__token_registration_behavior.sql
+V120__remove_ofy_key_fields.sql

db/src/main/resources/sql/flyway/V120__remove_ofy_key_fields.sql

@@ -0,0 +1,35 @@
+-- Copyright 2022 The Nomulus Authors. All Rights Reserved.
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+alter table "Domain" drop column billing_recurrence_history_id;
+alter table "Domain" drop column deletion_poll_message_history_id;
+alter table "Domain" drop column transfer_billing_cancellation_history_id;
+alter table "Domain" drop column transfer_billing_recurrence_history_id;
+alter table "Domain" drop column transfer_billing_event_history_id;
+
+alter table "DomainHistory" drop column billing_recurrence_history_id;
+alter table "DomainHistory" drop column deletion_poll_message_history_id;
+alter table "DomainHistory" drop column transfer_billing_cancellation_history_id;
+alter table "DomainHistory" drop column transfer_billing_recurrence_history_id;
+alter table "DomainHistory" drop column transfer_billing_event_history_id;
+
+alter table "GracePeriod" drop column billing_event_history_id;
+alter table "GracePeriod" drop column billing_event_domain_repo_id;
+alter table "GracePeriod" drop column billing_recurrence_history_id;
+alter table "GracePeriod" drop column billing_recurrence_domain_repo_id;
+
+alter table "GracePeriodHistory" drop column billing_event_history_id;
+alter table "GracePeriodHistory" drop column billing_event_domain_repo_id;
+alter table "GracePeriodHistory" drop column billing_recurrence_history_id;
+alter table "GracePeriodHistory" drop column billing_recurrence_domain_repo_id;

db/src/main/resources/sql/schema/nomulus.golden.sql

@@ -395,16 +395,11 @@ CREATE TABLE public."Domain" (
     autorenew_poll_message_id bigint,
     deletion_poll_message_id bigint,
     autorenew_end_time timestamp with time zone,
-    billing_recurrence_history_id bigint,
     autorenew_poll_message_history_id bigint,
-    deletion_poll_message_history_id bigint,
-    transfer_billing_recurrence_history_id bigint,
     transfer_autorenew_poll_message_history_id bigint,
-    transfer_billing_event_history_id bigint,
     transfer_history_entry_id bigint,
     transfer_repo_id text,
     transfer_poll_message_id_3 bigint,
-    transfer_billing_cancellation_history_id bigint,
     dns_refresh_request_time timestamp with time zone
 );
 
@@ -488,16 +483,11 @@ CREATE TABLE public."DomainHistory" (
     history_other_registrar_id text,
     history_period_unit text,
     history_period_value integer,
-    billing_recurrence_history_id bigint,
     autorenew_poll_message_history_id bigint,
-    deletion_poll_message_history_id bigint,
-    transfer_billing_recurrence_history_id bigint,
     transfer_autorenew_poll_message_history_id bigint,
-    transfer_billing_event_history_id bigint,
     transfer_history_entry_id bigint,
     transfer_repo_id text,
     transfer_poll_message_id_3 bigint,
-    transfer_billing_cancellation_history_id bigint,
     dns_refresh_request_time timestamp with time zone
 );
 
@@ -568,11 +558,7 @@ CREATE TABLE public."GracePeriod" (
     registrar_id text NOT NULL,
     domain_repo_id text NOT NULL,
     expiration_time timestamp with time zone NOT NULL,
-    type text NOT NULL,
-    billing_event_history_id bigint,
-    billing_recurrence_history_id bigint,
-    billing_event_domain_repo_id text,
-    billing_recurrence_domain_repo_id text
+    type text NOT NULL
 );
 
 
@@ -583,17 +569,13 @@ CREATE TABLE public."GracePeriod" (
 CREATE TABLE public."GracePeriodHistory" (
     grace_period_history_revision_id bigint NOT NULL,
     billing_event_id bigint,
-    billing_event_history_id bigint,
     billing_recurrence_id bigint,
-    billing_recurrence_history_id bigint,
     registrar_id text NOT NULL,
     domain_repo_id text NOT NULL,
     expiration_time timestamp with time zone NOT NULL,
     type text NOT NULL,
     domain_history_revision_id bigint,
-    grace_period_id bigint NOT NULL,
-    billing_event_domain_repo_id text,
-    billing_recurrence_domain_repo_id text
+    grace_period_id bigint NOT NULL
 );