zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-25 20:18:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

E-mail changes initiated from console to registrar contacts

Browse source 
Also, fix misspelling of "recipient."

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=237857289
This commit is contained in:
mmuller 2019-03-11 12:28:31 -07:00 • committed by Ben McIlwain
parent a7d099d2a3
commit 450e867534
10 changed files with 112 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

2
java/google/registry/ui/server/registrar/ConsoleOteSetupAction.java
View file

@ -221,7 +221,7 @@ public final class ConsoleOteSetupAction implements Runnable {
private void sendExternalUpdates(ImmutableMap<String, String> clientIdToTld) {
if (!sendEmailUtils.hasRecepients()) {
if (!sendEmailUtils.hasRecipients()) {
return;
}
String environment = Ascii.toLowerCase(String.valueOf(registryEnvironment));

2
java/google/registry/ui/server/registrar/ConsoleRegistrarCreatorAction.java
View file

@ -347,7 +347,7 @@ public final class ConsoleRegistrarCreatorAction implements Runnable {
return String.format(" %s: %s\n", name, value.orElse(null));
}
private void sendExternalUpdates() {
if (!sendEmailUtils.hasRecepients()) {
if (!sendEmailUtils.hasRecipients()) {
return;
}
String environment = Ascii.toLowerCase(String.valueOf(registryEnvironment));

15
java/google/registry/ui/server/registrar/RegistrarSettingsAction.java
View file

@ -15,6 +15,7 @@
package google.registry.ui.server.registrar;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.collect.ImmutableList.toImmutableList;
import static com.google.common.collect.ImmutableSet.toImmutableSet;
import static com.google.common.collect.Sets.difference;
import static google.registry.export.sheet.SyncRegistrarsSheetAction.enqueueRegistrarSheetSync;
@ -463,15 +464,15 @@ public class RegistrarSettingsAction implements Runnable, JsonActionRunner.JsonA
/**
* Determines if any changes were made to the registrar besides the lastUpdateTime, and if so,
* sends an email with a diff of the changes to the configured notification email address and
* enqueues a task to re-sync the registrar sheet.
* sends an email with a diff of the changes to the configured notification email address and all
* contact addresses and enqueues a task to re-sync the registrar sheet.
*/
private void sendExternalUpdatesIfNecessary(
Registrar existingRegistrar,
ImmutableSet<RegistrarContact> existingContacts,
Registrar updatedRegistrar,
ImmutableSet<RegistrarContact> updatedContacts) {
if (!sendEmailUtils.hasRecepients()) {
if (!sendEmailUtils.hasRecipients() && existingContacts.isEmpty()) {
return;
}
@ -498,7 +499,13 @@ public class RegistrarSettingsAction implements Runnable, JsonActionRunner.JsonA
environment,
existingRegistrar.getClientId(),
authResult.userIdForLogging(),
DiffUtils.prettyPrintDiffedMap(diffs, null)));
DiffUtils.prettyPrintDiffedMap(diffs, null)),
existingContacts.stream()
.map(
contact -> {
return contact.getEmailAddress();
})
.collect(toImmutableList()));
}
/** Thrown when a set of contacts doesn't meet certain constraints. */