From 440b06658dfcd2fa960ce3bcc31a6344e070d85d Mon Sep 17 00:00:00 2001 From: jianglai Date: Thu, 8 Jun 2017 11:45:17 -0400 Subject: [PATCH] Add MOE equivalency for 2017-12-01 sync There has been quite some descriptiveness between github and our internal build. I had to manually push a commit (1c1f95992a6f097408fa3b7b2d58263a138b3562) to bring github up-to-date. Now the github version is identical to what we'd get from doing a -dr-mkfoss. Hopefully the next time things will go smoothly. The culprit turns out to be MOE itself. It was not attributing changes to commits correctly when the change involves moving files as a result of modifications made to moe_config.json. When moe_config.json is altered in a CL to move files around, MOE always thinks that move happens in the first commit to be pushed. For example, if we have CL1,CL2,CL3, which correspond to CM1, CM2 and CM3 to be pushed to github, and a change to moe_config.json in CL3 moves a folder, MOE will think that move happens in CM1. This usually is not a problem when all commits are pushed, but when doing manual rebasing and cherry-picking, this will result in unintended dropped changes along with a commit. I'll do a push to github early next week to confirm that things are back to normal. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=177844920 --- java/google/registry/billing/BUILD | 2 ++ javatests/google/registry/billing/BUILD | 2 ++ 2 files changed, 4 insertions(+) diff --git a/java/google/registry/billing/BUILD b/java/google/registry/billing/BUILD index e983b8f97..a9bc84009 100644 --- a/java/google/registry/billing/BUILD +++ b/java/google/registry/billing/BUILD @@ -22,7 +22,9 @@ java_library( "@com_google_http_client", "@javax_servlet_api", "@joda_time", + "@org_apache_beam_runners_direct_java", "@org_apache_beam_runners_google_cloud_dataflow_java", "@org_apache_beam_sdks_java_core", + "@org_apache_beam_sdks_java_io_google_cloud_platform", ], ) diff --git a/javatests/google/registry/billing/BUILD b/javatests/google/registry/billing/BUILD index 3589d6198..7ffa8b0e7 100644 --- a/javatests/google/registry/billing/BUILD +++ b/javatests/google/registry/billing/BUILD @@ -20,8 +20,10 @@ java_library( "@com_google_truth_extensions_truth_java8_extension", "@joda_time", "@junit", + "@org_apache_beam_runners_direct_java", "@org_apache_beam_runners_google_cloud_dataflow_java", "@org_apache_beam_sdks_java_core", + "@org_apache_beam_sdks_java_io_google_cloud_platform", "@org_mockito_all", ], )