zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-24 19:48:32 +02:00
Code Issues Projects Releases Packages Wiki Activity

Reduce duplicate code in the servlets

Browse source 
Currently, all 4 servlets (backend, frontend, pubapi, tools) have duplicates of
the same exact code.

That's an anti-pattern!

Created a ServletBase they can all extend which has the duplicate code.

As a bonus, the tools servlet now runs the metric reporter, meaning tool
related metrics will now be reported!

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=219792176
This commit is contained in:
guyben 2018-11-02 06:59:50 -07:00 • committed by Michael Muller
parent 545b68ad9a
commit 3f6585fccc
10 changed files with 31 additions and 183 deletions
Download patch file Download diff file Expand all files Collapse all files

2
java/google/registry/module/tools/BUILD
View file

@ -20,6 +20,7 @@ java_library(
"//java/google/registry/keyring/kms",
"//java/google/registry/loadtest",
"//java/google/registry/mapreduce",
"//java/google/registry/module",
"//java/google/registry/monitoring/whitebox",
"//java/google/registry/request",
"//java/google/registry/request:modules",
@ -30,6 +31,7 @@ java_library(
"@com_google_dagger",
"@com_google_flogger",
"@com_google_flogger_system_backend",
"@com_google_monitoring_client_metrics",
"@javax_inject",
"@javax_servlet_api",
"@joda_time",