mirror of
https://github.com/google/nomulus.git
synced 2025-06-28 07:13:34 +02:00
Fix various Error Prone errors that were found by the FOSS build
Most common: - Unnecessary parentheses and operator precedence clarify (self-explanatory) - Reference equality--there were a few instances of using == or != improperly - Qualification of Builder (and similar) imports so that it's clear which type of Builder we're referring to - Marking some immutable classes with @Immutable since EP desires that all enums be deeply immutable - String.split() having "surprising behavior" ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=230971531
This commit is contained in:
parent
9cd37189c2
commit
3cf26ff9b6
52 changed files with 155 additions and 133 deletions
|
@ -70,7 +70,7 @@ public abstract class CommandTestCase<C extends Command> {
|
|||
public TemporaryFolder tmpDir = new TemporaryFolder();
|
||||
|
||||
@Before
|
||||
public final void beforeCommandTestCase() {
|
||||
public final void beforeCommandTestCase() throws Exception {
|
||||
// Ensure the UNITTEST environment has been set before constructing a new command instance.
|
||||
RegistryToolEnvironment.UNITTEST.setup(systemPropertyRule);
|
||||
command = newCommandInstance();
|
||||
|
@ -212,9 +212,10 @@ public abstract class CommandTestCase<C extends Command> {
|
|||
}
|
||||
|
||||
@SuppressWarnings("unchecked")
|
||||
protected C newCommandInstance() {
|
||||
protected C newCommandInstance() throws Exception {
|
||||
try {
|
||||
return (C) new TypeToken<C>(getClass()){}.getRawType().newInstance();
|
||||
return (C)
|
||||
new TypeToken<C>(getClass()) {}.getRawType().getDeclaredConstructor().newInstance();
|
||||
} catch (InstantiationException | IllegalAccessException e) {
|
||||
throw new RuntimeException(e);
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue