zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix various Error Prone errors that were found by the FOSS build

Browse source 
Most common:
- Unnecessary parentheses and operator precedence clarify (self-explanatory)
- Reference equality--there were a few instances of using == or != improperly
- Qualification of Builder (and similar) imports so that it's clear which type of Builder we're referring to
- Marking some immutable classes with @Immutable since EP desires that all enums be deeply immutable
- String.split() having "surprising behavior"

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=230971531
This commit is contained in:
gbrodman 2019-01-25 14:39:57 -08:00 • committed by Ben McIlwain
parent 9cd37189c2
commit 3cf26ff9b6
52 changed files with 155 additions and 133 deletions
Download patch file Download diff file Expand all files Collapse all files

11
java/google/registry/tools/ValidateEscrowDepositCommand.java
View file

@ -15,12 +15,12 @@
package google.registry.tools;
import static com.google.common.base.Preconditions.checkNotNull;
import static com.google.common.collect.ImmutableList.copyOf;
import static com.google.common.collect.Sets.difference;
import com.beust.jcommander.Parameter;
import com.beust.jcommander.Parameters;
import com.google.common.base.Joiner;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Ordering;
import google.registry.keyring.api.Keyring;
import google.registry.rde.Ghostryde;
@ -40,7 +40,6 @@ import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.Collection;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.SortedMap;
@ -141,17 +140,19 @@ final class ValidateEscrowDepositCommand implements Command {
}
System.out.println();
boolean good = true;
List<String> badHostnameRefs = copyOf(difference(hostnameRefs, hostnames));
ImmutableList<String> badHostnameRefs =
ImmutableList.copyOf(difference(hostnameRefs, hostnames));
if (!badHostnameRefs.isEmpty()) {
System.out.printf("Bad host refs: %s\n", Joiner.on(", ").join(badHostnameRefs));
good = false;
}
List<String> badContactRefs = copyOf(difference(contactRefs, contacts));
ImmutableList<String> badContactRefs = ImmutableList.copyOf(difference(contactRefs, contacts));
if (!badContactRefs.isEmpty()) {
System.out.printf("Bad contact refs: %s\n", Joiner.on(", ").join(badContactRefs));
good = false;
}
List<String> badRegistrarRefs = copyOf(difference(registrarRefs, registrars));
ImmutableList<String> badRegistrarRefs =
ImmutableList.copyOf(difference(registrarRefs, registrars));
if (!badRegistrarRefs.isEmpty()) {
System.out.printf("Bad registrar refs: %s\n", Joiner.on(", ").join(badRegistrarRefs));
good = false;