Fix various Error Prone errors that were found by the FOSS build

Most common:
- Unnecessary parentheses and operator precedence clarify (self-explanatory)
- Reference equality--there were a few instances of using == or != improperly
- Qualification of Builder (and similar) imports so that it's clear which type of Builder we're referring to
- Marking some immutable classes with @Immutable since EP desires that all enums be deeply immutable
- String.split() having "surprising behavior"

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=230971531
This commit is contained in:
gbrodman 2019-01-25 14:39:57 -08:00 committed by Ben McIlwain
parent 9cd37189c2
commit 3cf26ff9b6
52 changed files with 155 additions and 133 deletions

View file

@ -19,13 +19,14 @@ import static com.google.common.base.Preconditions.checkNotNull;
import com.google.common.collect.ImmutableRangeSet;
import com.google.common.collect.Range;
import com.google.common.collect.RangeSet;
import com.google.errorprone.annotations.Immutable;
import com.google.re2j.Matcher;
import com.google.re2j.Pattern;
import java.net.URI;
import java.util.Optional;
/** An IDN table for a particular TLD. */
@Immutable
public final class IdnTable {
/** Regular expression to match a line of an IDN table. */
@ -48,8 +49,8 @@ public final class IdnTable {
/** Public URL of policy for this IDN table, which is needed by RDE. */
private final URI policy;
/** {@link RangeSet} containing the valid codepoints in this table. */
private final RangeSet<Integer> validCodepoints;
/** {@link ImmutableRangeSet} containing the valid codepoints in this table. */
private final ImmutableRangeSet<Integer> validCodepoints;
/** Validates the language rules associated with this IDN table. */
private final Optional<LanguageValidator> languageValidator;
@ -58,7 +59,7 @@ public final class IdnTable {
String name,
URI url,
URI policy,
RangeSet<Integer> validCodepoints,
ImmutableRangeSet<Integer> validCodepoints,
Optional<LanguageValidator> languageValidator) {
this.name = name;
this.url = checkNotNull(url, "%s missing '# URL: http://foo.example/page' line", name);