zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-29 07:43:37 +02:00
Code Issues Projects Releases Packages Wiki Activity

Make dev project configurable (#371)

Browse source 
* Make dev project configurable

We should not hardcode our dev project in the public config file.

* Remove the use of .ext when using external properties

They are only needed when defining properties.
This commit is contained in:
Lai Jiang 2019-11-22 16:20:07 -05:00 • committed by GitHub
parent de02996f00
commit 3a6e55f2da
3 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
db/build.gradle
View file

@ -73,12 +73,12 @@ ext {
getCloudSqlCredential = { env, role -> getCloudSqlCredential = { env, role ->
def command = def command =
"""gsutil cp \ """gsutil cp \
gs://domain-registry-dev-deploy/cloudsql-credentials/${env}/${role}_credential.enc - | \ gs://${rootProject.devProject}-deploy/cloudsql-credentials/${env}/${role}_credential.enc - | \
base64 -d | \ base64 -d | \
gcloud kms decrypt --location global --keyring nomulus-tool-keyring \ gcloud kms decrypt --location global --keyring nomulus-tool-keyring \
--key nomulus-tool-key --plaintext-file=- \ --key nomulus-tool-key --plaintext-file=- \
--ciphertext-file=- \ --ciphertext-file=- \
--project=domain-registry-dev""" --project=${rootProject.devProject}"""
return execInBash(command, '/tmp') return execInBash(command, '/tmp')
} }

6
java_common.gradle
View file

@ -94,8 +94,8 @@ task initCoverageMinimums {
].asImmutable() ].asImmutable()
rootProject.ext.getMinCoverage = { key -> rootProject.ext.getMinCoverage = { key ->
if (rootProject.ext.coverageMinimums.containsKey(key)) { if (rootProject.coverageMinimums.containsKey(key)) {
return rootProject.ext.coverageMinimums.get(key) return rootProject.coverageMinimums.get(key)
} }
return 0.0 return 0.0
} }
@ -117,7 +117,7 @@ jacocoTestCoverageVerification {
// or MISSEDRATIO // or MISSEDRATIO
// - The 'minimum' threshold, given as a fraction or a percentage (including '%') // - The 'minimum' threshold, given as a fraction or a percentage (including '%')
limit { limit {
minimum = rootProject.ext.getMinCoverage(project.getName()) minimum = rootProject.getMinCoverage(project.getName())
} }
} }
} }

5
projects.gradle
View file

@ -15,7 +15,12 @@
// Mapping from environment names to GCP projects. // Mapping from environment names to GCP projects.
// Replace the values with the names of your deployment environments. // Replace the values with the names of your deployment environments.
// The projects to run your deployment Nomulus application.
rootProject.ext.projects = ['production': 'your-production-project', rootProject.ext.projects = ['production': 'your-production-project',
'sandbox' : 'your-sandbox-project', 'sandbox' : 'your-sandbox-project',
'alpha' : 'your-alpha-project', 'alpha' : 'your-alpha-project',
'crash' : 'your-crash-project'] 'crash' : 'your-crash-project']
// The project to host your development/deployment infrastructure. It hosts
// things like release artifacts, CI/CD system, etc.
rootProject.ext.devProject = 'your-dev-project'