zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-11 15:04:46 +02:00
Code Issues Projects Releases Packages Wiki Activity

Clarify un-avail reason on allocation-token-reserved domains (#725)

Browse source 
Apparently, in domain check responses, `avail=false, reason=Allocation token
required` was not sufficiently understood by all registrars. This changes it to
`avail=false, reason=Reserved; alloc. token required` to hopefully make it
crystal clear that the domain in question is reserved, i.e. if you were supposed
to be able to register this domain you'd already know it because we'd have
already given you the requisite allocation token.
This commit is contained in:
Ben McIlwain 2020-07-29 17:13:38 -04:00 • committed by GitHub
parent 04f032e226
commit 38f535fd49
3 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
core/src/test/java/google/registry/flows/CheckApiActionTest.java
View file

@ -277,7 +277,7 @@ class CheckApiActionTest {
"tier", "premium",
"status", "success",
"available", false,
"reason", "Allocation token required");
"reason", "Reserved; alloc. token required");
verifySuccessMetric(PREMIUM, RESERVED);
}

12
core/src/test/java/google/registry/flows/domain/DomainCheckFlowTest.java
View file

@ -143,7 +143,7 @@ class DomainCheckFlowTest extends ResourceCheckFlowTestCase<DomainCheckFlow, Dom
create(false, "example1.tld", "In use"),
create(false, "example2.tld", "The allocation token is invalid"),
create(false, "reserved.tld", "Reserved"),
create(false, "specificuse.tld", "Allocation token required"));
create(false, "specificuse.tld", "Reserved; alloc. token required"));
}
@Test
@ -156,7 +156,7 @@ class DomainCheckFlowTest extends ResourceCheckFlowTestCase<DomainCheckFlow, Dom
create(false, "example1.tld", "In use"),
create(true, "example2.tld", null),
create(false, "reserved.tld", "Reserved"),
create(false, "specificuse.tld", "Allocation token required"));
create(false, "specificuse.tld", "Reserved; alloc. token required"));
}
@Test
@ -173,7 +173,7 @@ class DomainCheckFlowTest extends ResourceCheckFlowTestCase<DomainCheckFlow, Dom
create(false, "example1.tld", "In use"),
create(false, "example2.tld", "Alloc token was already redeemed"),
create(false, "reserved.tld", "Reserved"),
create(false, "specificuse.tld", "Allocation token required"));
create(false, "specificuse.tld", "Reserved; alloc. token required"));
}
@Test
@ -222,7 +222,7 @@ class DomainCheckFlowTest extends ResourceCheckFlowTestCase<DomainCheckFlow, Dom
create(false, "example1.tld", "In use"),
create(false, "example2.tld", "Alloc token invalid for domain"),
create(false, "reserved.tld", "Reserved"),
create(false, "specificuse.tld", "Allocation token required"));
create(false, "specificuse.tld", "Reserved; alloc. token required"));
}
@Test
@ -276,7 +276,7 @@ class DomainCheckFlowTest extends ResourceCheckFlowTestCase<DomainCheckFlow, Dom
doCheckTest(
create(false, "collision.tld", "Cannot be delegated"),
create(false, "reserved.tld", "Reserved"),
create(false, "anchor.tld", "Allocation token required"),
create(false, "anchor.tld", "Reserved; alloc. token required"),
create(false, "allowedinsunrise.tld", "Reserved"),
create(false, "premiumcollision.tld", "Cannot be delegated"));
}
@ -410,7 +410,7 @@ class DomainCheckFlowTest extends ResourceCheckFlowTestCase<DomainCheckFlow, Dom
@Test
void testSuccess_anchorTenantReserved() throws Exception {
setEppInput("domain_check_anchor.xml");
doCheckTest(create(false, "anchor.tld", "Allocation token required"));
doCheckTest(create(false, "anchor.tld", "Reserved; alloc. token required"));
}
@Test