zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 00:47:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add RDAP metrics for non-search endpoints

Browse source 
This CL uses the previously-defined RDAP metrics class to record basic metrics
for all RDAP endpoints, and handles testing of non-search endpoints. Searches
are more complicated, and will be handled in future CLs.

The default wildcard type is now INVALID rather than NO_WILDCARD.

A change to getMatchingResources() (adding an additional parameter) is also included in this CL, as it was needed to set the incompleteness warning type correctly.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=175719265
This commit is contained in:
mountford 2017-11-14 12:36:06 -08:00 • committed by jianglai
parent 0ffd3553c3
commit 358fe68f09
14 changed files with 288 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

11
javatests/google/registry/rdap/RdapMetricsTest.java
View file

@ -47,7 +47,7 @@ public class RdapMetricsTest {
return RdapMetrics.RdapMetricInformation.builder()
.setEndpointType(EndpointType.DOMAINS)
.setSearchType(SearchType.NONE)
.setWildcardType(WildcardType.NO_WILDCARD)
.setWildcardType(WildcardType.INVALID)
.setPrefixLength(0)
.setIncludeDeleted(false)
.setRegistrarSpecified(false)
@ -80,7 +80,7 @@ public class RdapMetricsTest {
rdapMetrics.updateMetrics(
getBuilder().setPrefixLength(6).setNumDomainsRetrieved(1).build());
assertThat(RdapMetrics.numberOfDomainsRetrieved)
.hasDataSetForLabels(ImmutableSet.of(1), "DOMAINS", "NONE", "NO_WILDCARD", "5+", "NO")
.hasDataSetForLabels(ImmutableSet.of(1), "DOMAINS", "NONE", "INVALID", "5+", "NO")
.and()
.hasNoOtherValues();
}
@ -110,7 +110,7 @@ public class RdapMetricsTest {
.setIncompletenessWarningType(IncompletenessWarningType.COMPLETE)
.build());
assertThat(RdapMetrics.responses)
.hasValueForLabels(1, "DOMAINS", "NONE", "NO_WILDCARD", "200", "COMPLETE")
.hasValueForLabels(1, "DOMAINS", "NONE", "INVALID", "200", "COMPLETE")
.and()
.hasNoOtherValues();
}
@ -122,7 +122,7 @@ public class RdapMetricsTest {
.setIncompletenessWarningType(IncompletenessWarningType.TRUNCATED)
.build());
assertThat(RdapMetrics.responses)
.hasValueForLabels(1, "DOMAINS", "NONE", "NO_WILDCARD", "200", "TRUNCATED")
.hasValueForLabels(1, "DOMAINS", "NONE", "INVALID", "200", "TRUNCATED")
.and()
.hasNoOtherValues();
}
@ -134,7 +134,7 @@ public class RdapMetricsTest {
.setIncompletenessWarningType(IncompletenessWarningType.MIGHT_BE_INCOMPLETE)
.build());
assertThat(RdapMetrics.responses)
.hasValueForLabels(1, "DOMAINS", "NONE", "NO_WILDCARD", "200", "MIGHT_BE_INCOMPLETE")
.hasValueForLabels(1, "DOMAINS", "NONE", "INVALID", "200", "MIGHT_BE_INCOMPLETE")
.and()
.hasNoOtherValues();
}
@ -172,6 +172,7 @@ public class RdapMetricsTest {
rdapMetrics.updateMetrics(
getBuilder()
.setSearchType(SearchType.BY_DOMAIN_NAME)
.setWildcardType(WildcardType.NO_WILDCARD)
.setPrefixLength(7)
.setNumDomainsRetrieved(1)
.build());