zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-29 08:50:09 +02:00
Code Issues Projects Releases Packages Wiki Activity

In ExportConstantsTest, write path to golden file instead of contents

Browse source 
In my previous refactoring I failed to realize that getResource() was not
returning the contents of the file.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=142065550
This commit is contained in:
mcilwain 2016-12-14 14:34:31 -08:00 • committed by Ben McIlwain
parent 1ed1ba20ba
commit 352ef13160
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
javatests/google/registry/export/ExportConstantsTest.java
View file

@ -15,6 +15,7 @@
package google.registry.export; package google.registry.export;
import static com.google.common.base.Strings.repeat; import static com.google.common.base.Strings.repeat;
import static com.google.common.io.Resources.getResource;
import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertThat;
import static com.google.common.truth.Truth.assertWithMessage; import static com.google.common.truth.Truth.assertWithMessage;
import static google.registry.export.ExportConstants.getBackupKinds; import static google.registry.export.ExportConstants.getBackupKinds;
@ -28,7 +29,6 @@ import com.google.common.collect.FluentIterable;
import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSet; import com.google.common.collect.ImmutableSet;
import com.google.re2j.Pattern; import com.google.re2j.Pattern;
import java.util.List;
import javax.annotation.Nullable; import javax.annotation.Nullable;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
@ -70,16 +70,15 @@ public class ExportConstantsTest {
private static void checkKindsMatchGoldenFile( private static void checkKindsMatchGoldenFile(
String kindsName, String goldenFilename, ImmutableSet<String> actualKinds) { String kindsName, String goldenFilename, ImmutableSet<String> actualKinds) {
List<String> goldenKinds = extractListFromFile(goldenFilename);
String updateInstructions = String updateInstructions =
String.format( String.format(
UPDATE_INSTRUCTIONS_TEMPLATE, UPDATE_INSTRUCTIONS_TEMPLATE,
kindsName, kindsName,
Joiner.on('\n').join(goldenKinds), getResource(ExportConstantsTest.class, goldenFilename).toString(),
Joiner.on('\n').join(actualKinds)); Joiner.on('\n').join(actualKinds));
assertWithMessage(updateInstructions) assertWithMessage(updateInstructions)
.that(actualKinds) .that(actualKinds)
.containsExactlyElementsIn(goldenKinds) .containsExactlyElementsIn(extractListFromFile(goldenFilename))
.inOrder(); .inOrder();
} }