diff --git a/javatests/google/registry/testing/AbstractDomainBaseSubject.java b/javatests/google/registry/testing/AbstractDomainBaseSubject.java index 2a1f5794b..efb693f7b 100644 --- a/javatests/google/registry/testing/AbstractDomainBaseSubject.java +++ b/javatests/google/registry/testing/AbstractDomainBaseSubject.java @@ -36,7 +36,7 @@ public abstract class AbstractDomainBaseSubject public And hasFullyQualifiedDomainName(String fullyQualifiedDomainName) { return hasValue( fullyQualifiedDomainName, - getSubject().getFullyQualifiedDomainName(), + actual().getFullyQualifiedDomainName(), "has fullyQualifiedDomainName"); } @@ -45,19 +45,19 @@ public abstract class AbstractDomainBaseSubject } public And hasExactlyDsData(Set dsData) { - return hasValue(dsData, getSubject().getDsData(), "has dsData"); + return hasValue(dsData, actual().getDsData(), "has dsData"); } public And hasNumDsData(int num) { - return hasValue(num, getSubject().getDsData().size(), "has num dsData"); + return hasValue(num, actual().getDsData().size(), "has num dsData"); } public And hasLaunchNotice(LaunchNotice launchNotice) { - return hasValue(launchNotice, getSubject().getLaunchNotice(), "has launchNotice"); + return hasValue(launchNotice, actual().getLaunchNotice(), "has launchNotice"); } public And hasAuthInfoPwd(String pw) { - AuthInfo authInfo = getSubject().getAuthInfo(); + AuthInfo authInfo = actual().getAuthInfo(); return hasValue(pw, authInfo == null ? null : authInfo.getPw().getValue(), "has auth info pw"); } } diff --git a/javatests/google/registry/testing/AbstractEppResourceSubject.java b/javatests/google/registry/testing/AbstractEppResourceSubject.java index 3085b6fc8..fe847da8a 100644 --- a/javatests/google/registry/testing/AbstractEppResourceSubject.java +++ b/javatests/google/registry/testing/AbstractEppResourceSubject.java @@ -42,7 +42,7 @@ abstract class AbstractEppResourceSubject } private List getHistoryEntries() { - return DatastoreHelper.getHistoryEntries(getSubject()); + return DatastoreHelper.getHistoryEntries(actual()); } @SuppressWarnings("unchecked") @@ -54,12 +54,12 @@ abstract class AbstractEppResourceSubject public String getDisplaySubject() { return String.format( "%s with foreign key '%s'", - getSubject().getClass().getSimpleName(), - getSubject().getForeignKey()); + actual().getClass().getSimpleName(), + actual().getForeignKey()); } public And hasRepoId(long roid) { - return hasValue(roid, getSubject().getRepoId(), "has repoId"); + return hasValue(roid, actual().getRepoId(), "has repoId"); } public And hasNoHistoryEntries() { @@ -77,7 +77,7 @@ abstract class AbstractEppResourceSubject } public And hasNumHistoryEntriesOfType(HistoryEntry.Type type, int num) { - List entries = getHistoryEntriesOfType(getSubject(), type); + List entries = getHistoryEntriesOfType(actual(), type); if (entries.size() != num) { failWithBadResults( String.format("has this number of history entries of type %s", type.toString()), @@ -121,14 +121,14 @@ abstract class AbstractEppResourceSubject } public And hasStatusValue(StatusValue statusValue) { - if (!getSubject().getStatusValues().contains(statusValue)) { + if (!actual().getStatusValues().contains(statusValue)) { failWithRawMessage("%s should have had status value %s", getDisplaySubject(), statusValue); } return andChainer(); } public And doesNotHaveStatusValue(StatusValue statusValue) { - if (getSubject().getStatusValues().contains(statusValue)) { + if (actual().getStatusValues().contains(statusValue)) { failWithRawMessage( "%s should not have had status value %s", getDisplaySubject(), statusValue); } @@ -136,9 +136,9 @@ abstract class AbstractEppResourceSubject } public And hasExactlyStatusValues(StatusValue... statusValues) { - if (!ImmutableSet.copyOf(getSubject().getStatusValues()) + if (!ImmutableSet.copyOf(actual().getStatusValues()) .equals(ImmutableSet.copyOf(statusValues))) { - assertThat(getSubject().getStatusValues()).named("status values for " + getDisplaySubject()) + assertThat(actual().getStatusValues()).named("status values for " + getDisplaySubject()) .containsExactly((Object[]) statusValues); } return andChainer(); @@ -147,33 +147,33 @@ abstract class AbstractEppResourceSubject public And hasDeletionTime(DateTime deletionTime) { return hasValue( deletionTime, - getSubject().getDeletionTime(), + actual().getDeletionTime(), "has deletionTime"); } public And hasLastTransferTime(DateTime lastTransferTime) { return hasValue( lastTransferTime, - getSubject().getLastTransferTime(), + actual().getLastTransferTime(), "has lastTransferTime"); } public And hasLastTransferTimeNotEqualTo(DateTime lastTransferTime) { return doesNotHaveValue( lastTransferTime, - getSubject().getLastTransferTime(), + actual().getLastTransferTime(), "lastTransferTime"); } public And hasLastEppUpdateTime(DateTime lastUpdateTime) { return hasValue( lastUpdateTime, - getSubject().getLastEppUpdateTime(), + actual().getLastEppUpdateTime(), "has lastEppUpdateTime"); } public And hasLastEppUpdateTimeAtLeast(DateTime before) { - DateTime lastEppUpdateTime = getSubject().getLastEppUpdateTime(); + DateTime lastEppUpdateTime = actual().getLastEppUpdateTime(); if (lastEppUpdateTime == null || before.isAfter(lastEppUpdateTime)) { failWithBadResults("has lastEppUpdateTime at least", before, lastEppUpdateTime); } @@ -183,61 +183,61 @@ abstract class AbstractEppResourceSubject public And hasLastEppUpdateClientId(String clientId) { return hasValue( clientId, - getSubject().getLastEppUpdateClientId(), + actual().getLastEppUpdateClientId(), "has lastEppUpdateClientId"); } public And hasCurrentSponsorClientId(String clientId) { return hasValue( clientId, - getSubject().getCurrentSponsorClientId(), + actual().getCurrentSponsorClientId(), "has currentSponsorClientId"); } public And hasTransferStatus(TransferStatus transferStatus) { return hasValue( transferStatus, - getSubject().getTransferData().getTransferStatus(), + actual().getTransferData().getTransferStatus(), "has transferStatus"); } public And hasTransferRequestClientTrid(String clTrid) { return hasValue( clTrid, - getSubject().getTransferData().getTransferRequestTrid().getClientTransactionId(), + actual().getTransferData().getTransferRequestTrid().getClientTransactionId(), "has trid"); } public And hasPendingTransferExpirationTime(DateTime pendingTransferExpirationTime) { return hasValue( pendingTransferExpirationTime, - getSubject().getTransferData().getPendingTransferExpirationTime(), + actual().getTransferData().getPendingTransferExpirationTime(), "has pendingTransferExpirationTime"); } public And hasTransferGainingClientId(String gainingClientId) { return hasValue( gainingClientId, - getSubject().getTransferData().getGainingClientId(), + actual().getTransferData().getGainingClientId(), "has transfer ga"); } public And hasTransferLosingClientId(String losingClientId) { return hasValue( losingClientId, - getSubject().getTransferData().getLosingClientId(), + actual().getTransferData().getLosingClientId(), "has transfer losingClientId"); } public And isActiveAt(DateTime time) { - if (!isActive(getSubject(), time)) { + if (!isActive(actual(), time)) { fail("is active at " + time); } return andChainer(); } public And isNotActiveAt(DateTime time) { - if (isActive(getSubject(), time)) { + if (isActive(actual(), time)) { fail("is not active at " + time); } return andChainer(); diff --git a/javatests/google/registry/testing/ContactResourceSubject.java b/javatests/google/registry/testing/ContactResourceSubject.java index 931cd5186..a87e9fc46 100644 --- a/javatests/google/registry/testing/ContactResourceSubject.java +++ b/javatests/google/registry/testing/ContactResourceSubject.java @@ -37,18 +37,18 @@ public final class ContactResourceSubject } public And hasLocalizedPostalInfo(PostalInfo postalInfo) { - return hasValue(postalInfo, getSubject().getLocalizedPostalInfo(), "has localizedPostalInfo"); + return hasValue(postalInfo, actual().getLocalizedPostalInfo(), "has localizedPostalInfo"); } public And hasNullLocalizedPostalInfo() { - if (getSubject().getLocalizedPostalInfo() != null) { + if (actual().getLocalizedPostalInfo() != null) { fail("has null localized postal info"); } return andChainer(); } public And hasNonNullLocalizedPostalInfo() { - if (getSubject().getLocalizedPostalInfo() == null) { + if (actual().getLocalizedPostalInfo() == null) { fail("has non-null localized postal info"); } return andChainer(); @@ -58,12 +58,12 @@ public final class ContactResourceSubject PostalInfo postalInfo) { return hasValue( postalInfo, - getSubject().getInternationalizedPostalInfo(), + actual().getInternationalizedPostalInfo(), "has internationalizedPostalInfo"); } public And hasNullInternationalizedPostalInfo() { - if (getSubject().getInternationalizedPostalInfo() != null) { + if (actual().getInternationalizedPostalInfo() != null) { fail("has null internationalized postal info"); } return andChainer(); @@ -71,56 +71,56 @@ public final class ContactResourceSubject public And hasNonNullInternationalizedPostalInfo() { - if (getSubject().getInternationalizedPostalInfo() == null) { + if (actual().getInternationalizedPostalInfo() == null) { fail("has non-null internationalized postal info"); } return andChainer(); } public And hasNullEmailAddress() { - if (getSubject().getEmailAddress() != null) { + if (actual().getEmailAddress() != null) { fail("has null email address"); } return andChainer(); } public And hasNonNullEmailAddress() { - if (getSubject().getEmailAddress() == null) { + if (actual().getEmailAddress() == null) { fail("has non-null email address"); } return andChainer(); } public And hasNullVoiceNumber() { - if (getSubject().getVoiceNumber() != null) { + if (actual().getVoiceNumber() != null) { fail("has null voice number"); } return andChainer(); } public And hasNonNullVoiceNumber() { - if (getSubject().getVoiceNumber() == null) { + if (actual().getVoiceNumber() == null) { fail("has non-null voice number"); } return andChainer(); } public And hasNullFaxNumber() { - if (getSubject().getFaxNumber() != null) { + if (actual().getFaxNumber() != null) { fail("has null fax number"); } return andChainer(); } public And hasNonNullFaxNumber() { - if (getSubject().getFaxNumber() == null) { + if (actual().getFaxNumber() == null) { fail("has non-null fax number"); } return andChainer(); } public And hasAuthInfoPwd(String pw) { - AuthInfo authInfo = getSubject().getAuthInfo(); + AuthInfo authInfo = actual().getAuthInfo(); return hasValue(pw, authInfo == null ? null : authInfo.getPw().getValue(), "has auth info pw"); } diff --git a/javatests/google/registry/testing/DomainApplicationSubject.java b/javatests/google/registry/testing/DomainApplicationSubject.java index 6de6786c2..2e8bace99 100644 --- a/javatests/google/registry/testing/DomainApplicationSubject.java +++ b/javatests/google/registry/testing/DomainApplicationSubject.java @@ -33,9 +33,9 @@ public final class DomainApplicationSubject public And hasApplicationStatus( ApplicationStatus applicationStatus) { - if (!Objects.equals(getSubject().getApplicationStatus(), applicationStatus)) { + if (!Objects.equals(actual().getApplicationStatus(), applicationStatus)) { failWithBadResults( - "has application status", applicationStatus, getSubject().getApplicationStatus()); + "has application status", applicationStatus, actual().getApplicationStatus()); } return andChainer(); } @@ -44,16 +44,16 @@ public final class DomainApplicationSubject ApplicationStatus applicationStatus) { return doesNotHaveValue( applicationStatus, - getSubject().getApplicationStatus(), + actual().getApplicationStatus(), "application status"); } public And hasExactlyEncodedSignedMarks( EncodedSignedMark... encodedSignedMarks) { if (!Objects.equals( - ImmutableSet.copyOf(getSubject().getEncodedSignedMarks()), + ImmutableSet.copyOf(actual().getEncodedSignedMarks()), ImmutableSet.of(encodedSignedMarks))) { - assertThat(getSubject().getEncodedSignedMarks()) + assertThat(actual().getEncodedSignedMarks()) .named("the encoded signed marks of " + getDisplaySubject()) .containsExactly((Object[]) encodedSignedMarks); } @@ -61,9 +61,9 @@ public final class DomainApplicationSubject } public And hasNumEncodedSignedMarks(int num) { - if (getSubject().getEncodedSignedMarks().size() != num) { + if (actual().getEncodedSignedMarks().size() != num) { failWithBadResults( - "has this many encoded signed marks: ", num, getSubject().getEncodedSignedMarks().size()); + "has this many encoded signed marks: ", num, actual().getEncodedSignedMarks().size()); } return andChainer(); } diff --git a/javatests/google/registry/testing/DomainResourceSubject.java b/javatests/google/registry/testing/DomainResourceSubject.java index b8cdedd19..73f1cff42 100644 --- a/javatests/google/registry/testing/DomainResourceSubject.java +++ b/javatests/google/registry/testing/DomainResourceSubject.java @@ -33,31 +33,31 @@ public final class DomainResourceSubject extends ReflectiveSubjectFactory{} public And hasRegistrationExpirationTime(DateTime expiration) { - if (!Objects.equals(getSubject().getRegistrationExpirationTime(), expiration)) { + if (!Objects.equals(actual().getRegistrationExpirationTime(), expiration)) { failWithBadResults( "has registrationExpirationTime", expiration, - getSubject().getRegistrationExpirationTime()); + actual().getRegistrationExpirationTime()); } return andChainer(); } public And hasDeletePollMessage() { - if (getSubject().getDeletePollMessage() == null) { + if (actual().getDeletePollMessage() == null) { fail("has a delete poll message"); } return andChainer(); } public And hasNoDeletePollMessage() { - if (getSubject().getDeletePollMessage() != null) { + if (actual().getDeletePollMessage() != null) { fail("has no delete poll message"); } return andChainer(); } public And hasSmdId(String smdId) { - return hasValue(smdId, getSubject().getSmdId(), "has smdId"); + return hasValue(smdId, actual().getSmdId(), "has smdId"); } public DomainResourceSubject(FailureStrategy strategy, DomainResource subject) { diff --git a/javatests/google/registry/testing/HistoryEntrySubject.java b/javatests/google/registry/testing/HistoryEntrySubject.java index f340f2cef..623911489 100644 --- a/javatests/google/registry/testing/HistoryEntrySubject.java +++ b/javatests/google/registry/testing/HistoryEntrySubject.java @@ -40,7 +40,7 @@ public class HistoryEntrySubject extends Subject hasType(HistoryEntry.Type type) { - return hasValue(type, getSubject().getType(), "has type"); + return hasValue(type, actual().getType(), "has type"); } public And hasClientId(String clientId) { - return hasValue(clientId, getSubject().getClientId(), "has client ID"); + return hasValue(clientId, actual().getClientId(), "has client ID"); } public And hasPeriod() { - if (getSubject().getPeriod() == null) { + if (actual().getPeriod() == null) { fail("has a period"); } return new And(this); @@ -65,24 +65,24 @@ public class HistoryEntrySubject extends Subject hasPeriodYears(int years) { return hasPeriod().and() - .hasValue(Period.Unit.YEARS, getSubject().getPeriod().getUnit(), "has period in").and() - .hasValue(years, getSubject().getPeriod().getValue(), "has period length"); + .hasValue(Period.Unit.YEARS, actual().getPeriod().getUnit(), "has period in").and() + .hasValue(years, actual().getPeriod().getValue(), "has period length"); } public And hasNoXml() { - if (getSubject().getXmlBytes() != null) { + if (actual().getXmlBytes() != null) { fail("has no xml"); } return new And(this); } public And hasMetadataReason(String reason) { - return hasValue(reason, getSubject().getReason(), "has metadata reason"); + return hasValue(reason, actual().getReason(), "has metadata reason"); } public And hasMetadataRequestedByRegistrar( boolean requestedByRegistrar) { - if (getSubject().getRequestedByRegistrar() != requestedByRegistrar) { + if (actual().getRequestedByRegistrar() != requestedByRegistrar) { fail("has metadata requestedByRegistrar with value", requestedByRegistrar); } return new And(this); diff --git a/javatests/google/registry/testing/LogsSubject.java b/javatests/google/registry/testing/LogsSubject.java index b6094dcea..d12c6a266 100644 --- a/javatests/google/registry/testing/LogsSubject.java +++ b/javatests/google/registry/testing/LogsSubject.java @@ -37,8 +37,8 @@ public class LogsSubject extends Subject { } public And hasNoLogsAtLevel(Level level) { - for (LogRecord log : getSubject().getStoredLogRecords()) { - if (log.getLevel() == level) { + for (LogRecord log : actual().getStoredLogRecords()) { + if (log.getLevel().equals(level)) { failWithRawMessage( "Not true that there are no logs at level %s. Found <%s>.", level, log.getMessage()); } @@ -48,8 +48,8 @@ public class LogsSubject extends Subject { public And hasLogAtLevelWithMessage(Level level, String message) { boolean found = false; - for (LogRecord log : getSubject().getStoredLogRecords()) { - if (log.getLevel() == level && log.getMessage().contains(message)) { + for (LogRecord log : actual().getStoredLogRecords()) { + if (log.getLevel().equals(level) && log.getMessage().contains(message)) { found = true; break; }