zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 16:37:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add additional tests for the AllocationToken status transitions

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=245292932
This commit is contained in:
gbrodman 2019-04-25 13:09:52 -07:00 • committed by jianglai
parent a0f9e3b3dd
commit 312c1a46ab
2 changed files with 119 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
java/google/registry/model/domain/token/AllocationToken.java
View file

@ -264,9 +264,9 @@ public class AllocationToken extends BackupGroupRoot implements Buildable {
transitions, transitions,
TokenStatusTransition.class, TokenStatusTransition.class,
VALID_TOKEN_STATUS_TRANSITIONS, VALID_TOKEN_STATUS_TRANSITIONS,
"", "tokenStatusTransitions",
NOT_STARTED, NOT_STARTED,
""); "tokenStatusTransitions must start with NOT_STARTED");
return this; return this;
} }
} }

119
javatests/google/registry/model/domain/token/AllocationTokenTest.java
View file

@ -16,11 +16,16 @@ package google.registry.model.domain.token;
import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertThat;
import static com.google.common.truth.Truth8.assertThat; import static com.google.common.truth.Truth8.assertThat;
import static google.registry.model.domain.token.AllocationToken.TokenStatus.CANCELLED;
import static google.registry.model.domain.token.AllocationToken.TokenStatus.ENDED;
import static google.registry.model.domain.token.AllocationToken.TokenStatus.NOT_STARTED;
import static google.registry.model.domain.token.AllocationToken.TokenStatus.VALID;
import static google.registry.model.domain.token.AllocationToken.TokenType.SINGLE_USE; import static google.registry.model.domain.token.AllocationToken.TokenType.SINGLE_USE;
import static google.registry.model.domain.token.AllocationToken.TokenType.UNLIMITED_USE; import static google.registry.model.domain.token.AllocationToken.TokenType.UNLIMITED_USE;
import static google.registry.model.ofy.ObjectifyService.ofy; import static google.registry.model.ofy.ObjectifyService.ofy;
import static google.registry.testing.DatastoreHelper.persistResource; import static google.registry.testing.DatastoreHelper.persistResource;
import static google.registry.testing.JUnitBackports.assertThrows; import static google.registry.testing.JUnitBackports.assertThrows;
import static google.registry.util.DateTimeUtils.START_OF_TIME;
import static org.joda.time.DateTimeZone.UTC; import static org.joda.time.DateTimeZone.UTC;
import com.google.common.collect.ImmutableSet; import com.google.common.collect.ImmutableSet;
@ -30,7 +35,6 @@ import google.registry.model.EntityTestCase;
import google.registry.model.domain.token.AllocationToken.TokenStatus; import google.registry.model.domain.token.AllocationToken.TokenStatus;
import google.registry.model.domain.token.AllocationToken.TokenType; import google.registry.model.domain.token.AllocationToken.TokenType;
import google.registry.model.reporting.HistoryEntry; import google.registry.model.reporting.HistoryEntry;
import google.registry.util.DateTimeUtils;
import org.joda.time.DateTime; import org.joda.time.DateTime;
import org.junit.Test; import org.junit.Test;
@ -50,7 +54,7 @@ public class AllocationTokenTest extends EntityTestCase {
.setDiscountFraction(0.5) .setDiscountFraction(0.5)
.setTokenStatusTransitions( .setTokenStatusTransitions(
ImmutableSortedMap.<DateTime, TokenStatus>naturalOrder() ImmutableSortedMap.<DateTime, TokenStatus>naturalOrder()
.put(DateTimeUtils.START_OF_TIME, TokenStatus.NOT_STARTED) .put(START_OF_TIME, NOT_STARTED)
.put(DateTime.now(UTC), TokenStatus.VALID) .put(DateTime.now(UTC), TokenStatus.VALID)
.put(DateTime.now(UTC).plusWeeks(8), TokenStatus.ENDED) .put(DateTime.now(UTC).plusWeeks(8), TokenStatus.ENDED)
.build()) .build())
@ -151,6 +155,76 @@ public class AllocationTokenTest extends EntityTestCase {
.isEqualTo("Redemption history entry can only be specified for SINGLE_USE tokens"); .isEqualTo("Redemption history entry can only be specified for SINGLE_USE tokens");
} }
@Test
public void testSetTransitions_notStartOfTime() {
IllegalArgumentException thrown =
assertThrows(
IllegalArgumentException.class,
() ->
new AllocationToken.Builder()
.setTokenStatusTransitions(
ImmutableSortedMap.<DateTime, TokenStatus>naturalOrder()
.put(DateTime.now(UTC), NOT_STARTED)
.put(DateTime.now(UTC).plusDays(1), TokenStatus.VALID)
.put(DateTime.now(UTC).plusDays(2), TokenStatus.ENDED)
.build()));
assertThat(thrown)
.hasMessageThat()
.isEqualTo("tokenStatusTransitions map must start at START_OF_TIME.");
}
@Test
public void testSetTransitions_badInitialValue() {
IllegalArgumentException thrown =
assertThrows(
IllegalArgumentException.class,
() ->
new AllocationToken.Builder()
.setTokenStatusTransitions(
ImmutableSortedMap.<DateTime, TokenStatus>naturalOrder()
.put(START_OF_TIME, TokenStatus.VALID)
.put(DateTime.now(UTC), TokenStatus.ENDED)
.build()));
assertThat(thrown)
.hasMessageThat()
.isEqualTo("tokenStatusTransitions must start with NOT_STARTED");
}
@Test
public void testSetTransitions_invalidInitialTransitions() {
// NOT_STARTED can only go to VALID or CANCELLED
assertBadInitialTransition(NOT_STARTED);
assertBadInitialTransition(ENDED);
}
@Test
public void testSetTransitions_badTransitionsFromValid() {
// VALID can only go to ENDED or CANCELLED
assertBadTransition(
ImmutableSortedMap.<DateTime, TokenStatus>naturalOrder()
.put(START_OF_TIME, NOT_STARTED)
.put(DateTime.now(UTC), VALID)
.put(DateTime.now(UTC).plusDays(1), VALID)
.build(),
VALID,
VALID);
assertBadTransition(
ImmutableSortedMap.<DateTime, TokenStatus>naturalOrder()
.put(START_OF_TIME, NOT_STARTED)
.put(DateTime.now(UTC), VALID)
.put(DateTime.now(UTC).plusDays(1), NOT_STARTED)
.build(),
VALID,
NOT_STARTED);
}
@Test
public void testSetTransitions_terminalTransitions() {
// both ENDED and CANCELLED are terminal
assertTerminal(ENDED);
assertTerminal(CANCELLED);
}
@Test @Test
public void testBuild_noTokenType() { public void testBuild_noTokenType() {
IllegalArgumentException thrown = IllegalArgumentException thrown =
@ -177,4 +251,45 @@ public class AllocationTokenTest extends EntityTestCase {
() -> new AllocationToken.Builder().setToken("").setTokenType(SINGLE_USE).build()); () -> new AllocationToken.Builder().setToken("").setTokenType(SINGLE_USE).build());
assertThat(thrown).hasMessageThat().isEqualTo("Token must not be blank"); assertThat(thrown).hasMessageThat().isEqualTo("Token must not be blank");
} }
private void assertBadInitialTransition(TokenStatus status) {
assertBadTransition(
ImmutableSortedMap.<DateTime, TokenStatus>naturalOrder()
.put(START_OF_TIME, NOT_STARTED)
.put(DateTime.now(UTC), status)
.build(),
NOT_STARTED,
status);
}
private void assertBadTransition(
ImmutableSortedMap<DateTime, TokenStatus> map, TokenStatus from, TokenStatus to) {
IllegalArgumentException thrown =
assertThrows(
IllegalArgumentException.class,
() -> new AllocationToken.Builder().setTokenStatusTransitions(map));
assertThat(thrown)
.hasMessageThat()
.isEqualTo(
String.format("tokenStatusTransitions map cannot transition from %s to %s.", from, to));
}
private void assertTerminal(TokenStatus status) {
// The "terminal" message is slightly different so it must be tested separately
IllegalArgumentException thrown =
assertThrows(
IllegalArgumentException.class,
() ->
new AllocationToken.Builder()
.setTokenStatusTransitions(
ImmutableSortedMap.<DateTime, TokenStatus>naturalOrder()
.put(START_OF_TIME, NOT_STARTED)
.put(DateTime.now(UTC), VALID)
.put(DateTime.now(UTC).plusDays(1), status)
.put(DateTime.now(UTC).plusDays(2), CANCELLED)
.build()));
assertThat(thrown)
.hasMessageThat()
.isEqualTo(String.format("tokenStatusTransitions map cannot transition from %s.", status));
}
} }