zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Reduce number of authentication/authorization log statements

Browse source 
The auth logging has been useful, but it now generates a sizeable percentage of all logging, because it spits out three to five lines for every request in the system. This CL reduces that to two to three. We may eventually want to reduce it further, but this is a good start.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=164146182
This commit is contained in:
mountford 2017-08-03 10:46:43 -07:00 • committed by Ben McIlwain
parent 2707208100
commit 2f238a2c77
1 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
java/google/registry/request/auth/RequestAuthenticator.java
View file

@ -146,7 +146,6 @@ public class RequestAuthenticator {
}
break;
}
logger.info("Authorized");
return Optional.of(authResult);
}
@ -164,11 +163,10 @@ public class RequestAuthenticator {
// App Engine internal authentication, using the queue name header
case INTERNAL:
// checkAuthConfig will have insured that the user policy is not USER.
logger.info("Checking internal auth");
{
AuthResult authResult = appEngineInternalAuthenticationMechanism.authenticate(req);
if (authResult.isAuthenticated()) {
logger.infofmt("Authenticated: %s", authResult);
logger.infofmt("Authenticated via internal auth: %s", authResult);
return authResult;
}
}
@ -177,10 +175,10 @@ public class RequestAuthenticator {
case API:
// checkAuthConfig will have insured that the user policy is not IGNORED.
for (AuthenticationMechanism authMechanism : apiAuthenticationMechanisms) {
logger.infofmt("Checking %s", authMechanism);
AuthResult authResult = authMechanism.authenticate(req);
if (authResult.isAuthenticated()) {
logger.infofmt("Authenticated: %s", authResult);
logger.infofmt(
"Authenticated via %s: %s", authMechanism.getClass().getSimpleName(), authResult);
return authResult;
}
}
@ -188,10 +186,9 @@ public class RequestAuthenticator {
// Legacy authentication via UserService
case LEGACY:
// checkAuthConfig will have insured that the user policy is not IGNORED.
logger.info("Checking legacy auth");
AuthResult authResult = legacyAuthenticationMechanism.authenticate(req);
if (authResult.isAuthenticated()) {
logger.infofmt("Authenticated: %s", authResult);
logger.infofmt("Authenticated via legacy auth: %s", authResult);
return authResult;
}
break;