zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-04-29 19:47:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Disable TLS tests related to v1.1 (#1074)

Browse source 
There is no need for this test now because we've past the enforcement
date. We should take out the entire enforcement date logic but right now
this test is failing because TLS 1.1 is not being supported anymore by
the latest release of JDK 11.

The other test is a bit tricky to fix, see comment.

Disable these tests for now to unblock development.
This commit is contained in:
Lai Jiang 2021-04-13 10:30:58 -04:00 • committed by GitHub
parent 101c8a5db7
commit 2d4cfe51f9
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
networking/src/test/java/google/registry/networking/handler/SslServerInitializerTest.java
View file

@ -53,6 +53,7 @@ import javax.net.ssl.SSLHandshakeException;
import javax.net.ssl.SSLParameters;
import javax.net.ssl.SSLSession;
import org.joda.time.DateTime;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.extension.RegisterExtension;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
@ -306,6 +307,11 @@ class SslServerInitializerTest {
assertThat(sslSession.getPeerCertificates()).asList().containsExactly(serverSsc.cert());
}
// This test is a bit tricky to fix because apparently some new OpenJDK 11 version does no
// support TLS 1.1 anymore, and in that case it throws a ClosedChannelException instead of a
// SSLHandShakeException. It's going to be hard to accommodate both the OpenSSL and the JDK
// provider. Disable it for now to unblock people.
@Disabled
@ParameterizedTest
@MethodSource("provideTestCombinations")
void testFailure_protocolNotAccepted(SslProvider sslProvider) throws Exception {
@ -330,6 +336,7 @@ class SslServerInitializerTest {
SSLHandshakeException.class);
}
@Disabled
@ParameterizedTest
@MethodSource("provideTestCombinations")
void testSuccess_protocolNotAccepted_beforeEnforcementDate(SslProvider sslProvider)