zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-19 02:39:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix up a comment based on investigation into billing events

Browse source 
Please see the linked bug for more context--I believe this is correct based on what I've observed.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=245423464
This commit is contained in:
gbrodman 2019-04-26 08:20:12 -07:00 • committed by jianglai
parent 94aa5cd6ec
commit 29b9f04aaa
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
java/google/registry/flows/domain/DomainDeleteFlow.java
View file

@ -195,9 +195,10 @@ public final class DomainDeleteFlow implements TransactionalFlow {
redemptionTime,
clientId)));
// Note: The expiration time is unchanged, so if it's before the new deletion time, there will
// be a "phantom autorenew" where the expiration time advances but no billing event or poll
// message are produced (since we are ending the autorenew recurrences at "now" below). For
// now at least this is working as intended.
// be a "phantom autorenew" where the expiration time advances. No poll message will be
// produced (since we are ending the autorenew recurrences at "now" below) and the billing
// event that's created will be automatically cancelled by the corresponding Cancellation
// event that we create below. For now, at least, this is working as intended.
}
// Enqueue the deletion poll message if the delete is asynchronous or if requested by a