zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-12 05:58:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Make parameter names in generate_sql_schema command consistent (#250)

Browse source 
* Make parameter names in generate_sql_schema command consistent

The rest of the nomulus commands use underscores for delimiting words in
parameter names, so this should too.

Also fixed capitalization of some proper nouns.
This commit is contained in:
Ben McIlwain 2019-09-04 11:10:22 -04:00 • committed by GitHub
parent c4b87a1d13
commit 28700cd610
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

19
core/src/test/java/google/registry/tools/GenerateSqlSchemaCommandTest.java
View file

@ -28,6 +28,7 @@ import org.junit.runners.JUnit4;
import org.testcontainers.containers.PostgreSQLContainer;
/** Unit tests for {@link google.registry.tools.GenerateSqlSchemaCommand}. */
@RunWith(JUnit4.class)
public class GenerateSqlSchemaCommandTest extends CommandTestCase<GenerateSqlSchemaCommand> {
@ -53,9 +54,9 @@ public class GenerateSqlSchemaCommandTest extends CommandTestCase<GenerateSqlSch
@Test
public void testSchemaGeneration() throws Exception {
runCommand(
"--out-file=" + tmp.getRoot() + File.separatorChar + "schema.sql",
"--db-host=" + containerHostName,
"--db-port=" + containerPort);
"--out_file=" + tmp.getRoot() + File.separatorChar + "schema.sql",
"--db_host=" + containerHostName,
"--db_port=" + containerPort);
// We're just interested in verifying that there is a schema file generated, we don't do any
// checks on the contents, this would make the test too brittle and serves no real purpose.
@ -66,18 +67,18 @@ public class GenerateSqlSchemaCommandTest extends CommandTestCase<GenerateSqlSch
@Test
public void testIncompatibleFlags() throws Exception {
runCommand(
"--out-file=" + tmp.getRoot() + File.separatorChar + "schema.sql",
"--db-host=" + containerHostName,
"--db-port=" + containerPort,
"--start-postgresql");
"--out_file=" + tmp.getRoot() + File.separatorChar + "schema.sql",
"--db_host=" + containerHostName,
"--db_port=" + containerPort,
"--start_postgresql");
assertInStderr(GenerateSqlSchemaCommand.DB_OPTIONS_CLASH);
}
@Test
public void testDockerPostgresql() throws Exception {
runCommand(
"--start-postgresql",
"--out-file=" + tmp.getRoot() + File.separatorChar + "schema.sql");
"--start_postgresql",
"--out_file=" + tmp.getRoot() + File.separatorChar + "schema.sql");
assertThat(new File(tmp.getRoot(), "schema.sql").exists()).isTrue();
}
}