From 28499d23a0675ad05a641668e64a21b3ab3f4953 Mon Sep 17 00:00:00 2001
From: Michael Muller <mmuller@enduden.com>
Date: Tue, 26 Nov 2019 13:20:27 -0500
Subject: [PATCH] Print filenames that need to be reformatted (#386)

* Print filenames that need to be reformatted

Print the names of all java files that need reformatting during the check and
reformat operations.
---
 java-format/google-java-format-git-diff.sh | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/java-format/google-java-format-git-diff.sh b/java-format/google-java-format-git-diff.sh
index aef381d75..1ef45737a 100755
--- a/java-format/google-java-format-git-diff.sh
+++ b/java-format/google-java-format-git-diff.sh
@@ -41,6 +41,16 @@ where:
 
 SCRIPT_DIR="$(realpath $(dirname $0))"
 
+function showNoncompliantFiles() {
+  local forkPoint="$1"
+  local message="$2"
+
+  git diff -U0 ${forkPoint} | \
+      ${SCRIPT_DIR}/google-java-format-diff.py -p1 | \
+      awk -v "message=$message" \
+          '/\+\+\+ ([^ ]*)/ { print message $2 }' 1>&2
+}
+
 function callGoogleJavaFormatDiff() {
   local forkPoint
   forkPoint=$(git merge-base --fork-point origin/master)
@@ -48,10 +58,12 @@ function callGoogleJavaFormatDiff() {
   local callResult
   case "$1" in
     "check")
+      showNoncompliantFiles "$forkPoint" "\033[1mNeeds formatting: "
       callResult=$(git diff -U0 ${forkPoint} | \
           ${SCRIPT_DIR}/google-java-format-diff.py -p1 | wc -l)
       ;;
     "format")
+      showNoncompliantFiles "$forkPoint" "\033[1mReformatting: "
       callResult=$(git diff -U0 ${forkPoint} | \
           ${SCRIPT_DIR}/google-java-format-diff.py -p1 -i)
       ;;
@@ -60,6 +72,7 @@ function callGoogleJavaFormatDiff() {
           ${SCRIPT_DIR}/google-java-format-diff.py -p1)
       ;;
   esac
+  echo -e "\033[0m" 1>&2
   echo "${callResult}"
   exit 0
 }