zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove @Inject annotation in StackDriverWriter

Browse source 
StackDriverWriter is provided by java.google.registry.monitoring.whitebox.StackdriverModule. The @Inject annotation in its constructor is not used. It also uses outdated named binding like @Named(stackdriverGcpProject) which causes confusion because that name is not provided anywhere in the code.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=169922096
This commit is contained in:
jianglai 2017-09-25 10:04:40 -07:00 • committed by Ben McIlwain
parent af570dcafe
commit 2814561e92
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
java/google/registry/monitoring/metrics/stackdriver/StackdriverWriter.java
View file

@ -57,8 +57,6 @@ import java.util.List;
import java.util.Queue;
import java.util.logging.Logger;
import javax.annotation.concurrent.NotThreadSafe;
import javax.inject.Inject;
import javax.inject.Named;
import org.joda.time.DateTime;
import org.joda.time.Interval;
import org.joda.time.format.DateTimeFormatter;
@ -140,13 +138,12 @@ public class StackdriverWriter implements MetricWriter {
* <p>The monitoringClient must have read and write permissions to the Cloud Monitoring API v3 on
* the provided project.
*/
@Inject
public StackdriverWriter(
Monitoring monitoringClient,
@Named("stackdriverGcpProject") String project,
String project,
MonitoredResource monitoredResource,
@Named("stackdriverMaxQps") int maxQps,
@Named("stackdriverMaxPointsPerRequest") int maxPointsPerRequest) {
int maxQps,
int maxPointsPerRequest) {
this.monitoringClient = checkNotNull(monitoringClient);
this.projectResource = "projects/" + checkNotNull(project);
this.monitoredResource = monitoredResource;