Fix some statically detected code issues

This includes: unnecessary semicolons, suppress warnings, switch statements, final/private qualifiers, Optional wrapping, conditionals, both inline and non-inline variables, ternaries, Collection putAll() calls, StringBuilders, and throws declarations.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=244182539
This commit is contained in:
mcilwain 2019-04-18 07:34:10 -07:00 committed by jianglai
parent 9f360587ff
commit 24bb78bd16
54 changed files with 107 additions and 158 deletions

View file

@ -41,8 +41,7 @@ public abstract class ParameterConverterValidator<T>
convert(value);
} catch (IllegalArgumentException e) {
ParameterException pe =
new ParameterException(String.format("%s=%s %s", name, value, messageForInvalid));
pe.initCause(e);
new ParameterException(String.format("%s=%s %s", name, value, messageForInvalid), e);
throw pe;
}
}