zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 17:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix some statically detected code issues

Browse source 
This includes: unnecessary semicolons, suppress warnings, switch statements, final/private qualifiers, Optional wrapping, conditionals, both inline and non-inline variables, ternaries, Collection putAll() calls, StringBuilders, and throws declarations.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=244182539
This commit is contained in:
mcilwain 2019-04-18 07:34:10 -07:00 • committed by jianglai
parent 9f360587ff
commit 24bb78bd16
54 changed files with 107 additions and 158 deletions
Download patch file Download diff file Expand all files Collapse all files

2
java/google/registry/reporting/icann/DnsCountQueryCoordinator.java
View file

@ -34,7 +34,7 @@ public interface DnsCountQueryCoordinator {
*
* If your report query requires any additional parameters, add them here.
*/
public class Params {
class Params {
public BigqueryConnection bigquery;
/** The Google Cloud project id. */

4
java/google/registry/reporting/icann/DnsCountQueryCoordinatorModule.java
View file

@ -33,8 +33,6 @@ public class DnsCountQueryCoordinatorModule {
@Config("projectId") String projectId) {
DnsCountQueryCoordinator.Params params =
new DnsCountQueryCoordinator.Params(bigquery, projectId);
DnsCountQueryCoordinator result =
instantiate(getClassFromString(customClass, DnsCountQueryCoordinator.class), params);
return result;
return instantiate(getClassFromString(customClass, DnsCountQueryCoordinator.class), params);
}
}

14
java/google/registry/reporting/icann/IcannReportingModule.java
View file

@ -88,14 +88,12 @@ public final class IcannReportingModule {
static BigqueryConnection provideBigqueryConnection(
BigqueryConnection.Builder bigQueryConnectionBuilder) {
try {
BigqueryConnection connection =
bigQueryConnectionBuilder
.setExecutorService(MoreExecutors.newDirectExecutorService())
.setDatasetId(ICANN_REPORTING_DATA_SET)
.setOverwrite(true)
.setPollInterval(Duration.standardSeconds(1))
.build();
return connection;
return bigQueryConnectionBuilder
.setExecutorService(MoreExecutors.newDirectExecutorService())
.setDatasetId(ICANN_REPORTING_DATA_SET)
.setOverwrite(true)
.setPollInterval(Duration.standardSeconds(1))
.build();
} catch (Throwable e) {
throw new RuntimeException("Could not initialize BigqueryConnection!", e);
}