zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix some statically detected code issues

Browse source 
This includes: unnecessary semicolons, suppress warnings, switch statements, final/private qualifiers, Optional wrapping, conditionals, both inline and non-inline variables, ternaries, Collection putAll() calls, StringBuilders, and throws declarations.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=244182539
This commit is contained in:
mcilwain 2019-04-18 07:34:10 -07:00 • committed by jianglai
parent 9f360587ff
commit 24bb78bd16
54 changed files with 107 additions and 158 deletions
Download patch file Download diff file Expand all files Collapse all files

16
java/google/registry/model/eppinput/EppInput.java
View file

@ -151,14 +151,10 @@ public class EppInput extends ImmutableObject {
/** Get the extension based on type, or null. If there are multiple, it chooses the first. */
public <E extends CommandExtension> Optional<E> getSingleExtension(Class<E> clazz) {
return Optional.ofNullable(
getCommandWrapper()
.getExtensions()
.stream()
.filter(clazz::isInstance)
.map(clazz::cast)
.findFirst()
.orElse(null));
return getCommandWrapper().getExtensions().stream()
.filter(clazz::isInstance)
.map(clazz::cast)
.findFirst();
}
/** A tag that goes inside of an EPP {@literal <command>}. */
@ -225,7 +221,7 @@ public class EppInput extends ImmutableObject {
REJECT,
@XmlEnumValue("request")
REQUEST;
REQUEST
}
@XmlAttribute(name = "op")
@ -251,7 +247,7 @@ public class EppInput extends ImmutableObject {
/** Request the next poll message. */
@XmlEnumValue("req")
REQUEST;
REQUEST
}
@XmlAttribute