Allow the same LaunchPhase to be used for both start-date and end-date sunrise

Also changed the name of "verifyRegistryStateAllowsLaunchFlows" to "verifyRegistryStateAllowsApplicationFlows", because there are now launch flows that don't use applications (start-date sunrise).

Finally, added a test to showcase the "super-user" power that EPPs with Anchor Tenants have. There's no change in behavior in that regard in this CL - we just add a test to make it explicit.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=187517199
This commit is contained in:
guyben 2018-03-01 12:34:50 -08:00 committed by jianglai
parent ef26dabf32
commit 24799b394d
11 changed files with 36 additions and 26 deletions

View file

@ -1778,6 +1778,19 @@ public class DomainCreateFlowTest extends ResourceFlowTestCase<DomainCreateFlow,
assertNoLordn("0000001761376042759136-65535", null);
}
/** Tests possible confusion caused by the common start-date and end-date sunrise LaunchPhase. */
@Test
public void testFail_sunriseRegistration_withEncodedSignedMark() throws Exception {
createTld("tld", TldState.SUNRISE);
clock.setTo(DateTime.parse("2014-09-09T09:09:09Z"));
setEppInput("domain_create_registration_start_date_sunrise_encoded_signed_mark.xml");
persistContactsAndHosts();
EppException thrown =
assertThrows(NoGeneralRegistrationsInCurrentPhaseException.class, this::runFlow);
assertAboutEppExceptions().that(thrown).marshalsToXml();
}
@Test
public void testFail_startDateSunriseRegistration_wrongEncodedSignedMark() throws Exception {
createTld("tld", TldState.START_DATE_SUNRISE);

View file

@ -20,7 +20,7 @@
</create>
<extension>
<launch:create xmlns:launch="urn:ietf:params:xml:ns:launch-1.0" type="registration">
<launch:phase name="start-date">sunrise</launch:phase>
<launch:phase>sunrise</launch:phase>
</launch:create>
<metadata:metadata xmlns:metadata="urn:google:params:xml:ns:metadata-1.0">
<metadata:requestedByRegistrar>true</metadata:requestedByRegistrar>

View file

@ -22,7 +22,7 @@
<launch:create
xmlns:launch="urn:ietf:params:xml:ns:launch-1.0"
type="registration">
<launch:phase name="start-date">sunrise</launch:phase>
<launch:phase>sunrise</launch:phase>
</launch:create>
</extension>
<clTRID>ABC-12345</clTRID>

View file

@ -20,7 +20,7 @@
</create>
<extension>
<launch:create xmlns:launch="urn:ietf:params:xml:ns:launch-1.0" type="registration">
<launch:phase name="start-date">sunrise</launch:phase>
<launch:phase>sunrise</launch:phase>
<launch:notice>
<launch:noticeID>370d0b7c9223372036854775807</launch:noticeID>
<launch:notAfter>2010-08-16T09:00:00.0Z</launch:notAfter>

File diff suppressed because one or more lines are too long