zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-22 02:36:03 +02:00
Code Issues Projects Releases Packages Wiki Activity

Rename whitelist -> allow list (#635)

Browse source 
* Rename whitelist -> allow list

* Merge branch 'master' into allowlist-denylist
This commit is contained in:
Ben McIlwain 2020-06-18 18:36:05 -04:00 • committed by GitHub
parent f7ca068f8e
commit 23310bd688
91 changed files with 448 additions and 453 deletions
Download patch file Download diff file Expand all files Collapse all files

12
util/src/main/java/google/registry/util/Retrier.java
View file

@ -78,9 +78,9 @@ public class Retrier implements Serializable {
* Retries a unit of work in the face of transient errors and returns the result.
*
* <p>Retrying is done a fixed number of times, with exponential backoff, if the exception that is
* thrown is on a whitelist of retryable errors. If the error is not on the whitelist, or if the
* thread is interrupted, or if the allowable number of attempts has been exhausted, the original
* exception is propagated through to the caller. Checked exceptions are wrapped in a
* thrown is on an allow list of retryable errors. If the error is not on the allow list, or if
* the thread is interrupted, or if the allowable number of attempts has been exhausted, the
* original exception is propagated through to the caller. Checked exceptions are wrapped in a
* RuntimeException, while unchecked exceptions are propagated as-is.
*
* <p>Uses a default FailureReporter that logs before each retry.
@ -112,9 +112,9 @@ public class Retrier implements Serializable {
* Retries a unit of work in the face of transient errors and returns the result.
*
* <p>Retrying is done a fixed number of times, with exponential backoff, if the exception that is
* thrown is on a whitelist of retryable errors. If the error is not on the whitelist, or if the
* thread is interrupted, or if the allowable number of attempts has been exhausted, the original
* exception is propagated through to the caller. Checked exceptions are wrapped in a
* thrown is on an allow list of retryable errors. If the error is not on the allow list, or if
* the thread is interrupted, or if the allowable number of attempts has been exhausted, the
* original exception is propagated through to the caller. Checked exceptions are wrapped in a
* RuntimeException, while unchecked exceptions are propagated as-is.
*
* @return the value returned by the {@link Callable}.

8
util/src/main/java/google/registry/util/SqlTemplate.java
View file

@ -48,12 +48,12 @@ public final class SqlTemplate {
/**
* Adds a key/value that should be substituted an individual variable in the template.
*
* <p>Your template variables should appear as follows: {@code WHERE foo = '%BAR%'} and you
* would call {@code .put("BAR", "some value"} to safely substitute it with a value. Only
* whitelisted characters (as defined by {@link #LEGAL_SUBSTITUTIONS}) are allowed in values.
* <p>Your template variables should appear as follows: {@code WHERE foo = '%BAR%'} and you would
* call {@code .put("BAR", "some value"} to safely substitute it with a value. Only allow-listed
* characters (as defined by {@link #LEGAL_SUBSTITUTIONS}) are allowed in values.
*
* @param key uppercase string that can have digits and underscores
* @param value substitution value, comprised of whitelisted characters
* @param value substitution value, composed of allow-listed characters
* @throws IllegalArgumentException if key or value has bad chars or duplicate keys were added
*/
public SqlTemplate put(String key, String value) {

2
util/src/main/java/google/registry/util/X509Utils.java
View file

@ -52,7 +52,7 @@ public final class X509Utils {
* SHA-256 digest of the certificate.
*
* <p>Note that this must match the method used by the GFE to generate the client certificate hash
* so that the two will match when we check against the whitelist.
* so that the two will match when we check against the allow list.
*/
public static String getCertificateHash(X509Certificate cert) {
try {