mirror of
https://github.com/google/nomulus.git
synced 2025-05-15 08:57:12 +02:00
Set correct auth settings for all actions
A test has been added to RequestHandlerTest, making sure that, while we merely log errors for the time being, the correct dummy AuthResult is being created. Most actions use the default settings, which have been changed to INTERNAL / APP / IGNORED. Actions with non-default settings are: INTERNAL/NONE/PUBLIC (non-auth public endpoints) CheckApiAction WhoisHttpServer Rdap*Action INTERNAL,API/APP/ADMIN (things currently protected by web.xml) EppTlsAction EppToolAction CreateGroupsAction CreatePremiumListAction DeleteEntityAction List*sAction UpdatePremiumListAction VerifyOteAction WhoisServer INTERNAL,API,LEGACY/USER/PUBLIC (registrar console) RegistrarPaymentAction RegistrarPaymentSetupAction RegistrarSettingsAction EppConsoleAction INTERNAL,API,LEGACY/NONE/PUBLIC (registrar console main page) ConsoleUiAction ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=149761652
This commit is contained in:
parent
f5e76868f0
commit
1f000b94e6
38 changed files with 450 additions and 133 deletions
|
@ -59,8 +59,7 @@ public @interface Auth {
|
|||
AuthMethod[] methods() default { AuthMethod.INTERNAL };
|
||||
|
||||
/** Required minimum level of authentication for this action. */
|
||||
// TODO(mountford) This should probably default to APP eventually.
|
||||
AuthLevel minimumLevel() default AuthLevel.NONE;
|
||||
AuthLevel minimumLevel() default AuthLevel.APP;
|
||||
|
||||
/** Required user authorization policy for this action. */
|
||||
UserPolicy userPolicy() default UserPolicy.IGNORED;
|
||||
|
|
|
@ -70,6 +70,7 @@ public class RequestAuthenticator {
|
|||
case USER:
|
||||
if (authResult.authLevel() != AuthLevel.USER) {
|
||||
logger.info("Not authorized; no authenticated user");
|
||||
// TODO(mountford): change this so that the caller knows to return a more helpful error
|
||||
return Optional.absent();
|
||||
}
|
||||
break;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue