Remove failing tests from Nomulus GCB pipeline

Also upgrade to Gradle 5.4.1.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246829399
This commit is contained in:
jianglai 2019-05-06 08:23:00 -07:00
parent 3483f348dc
commit 1dcbfae314
3 changed files with 19 additions and 2 deletions

View file

@ -41,6 +41,19 @@ def fragileTestPatterns = [
"google/registry/model/server/KmsSecretRevisionTest.*" "google/registry/model/server/KmsSecretRevisionTest.*"
] ]
// Tests that fail when running Gradle in a docker container, e. g. when
// building the release artifacts in Google Cloud Build.
def dockerIncompatibleTestPatterns = [
// The webdriver tests start headless Chrome in a Docker container,
// resulting in Docker-in-Docker complications.
"google/registry/webdriver/*",
// PathParameterTest includes tests which validate that file permissions are
// respected. However when running in Docker the user is root by default, so
// every file is read/write-able. There is no way to exclude specific test
// methods, so we exclude the whole test class.
"google/registry/tools/params/PathParameterTest.*"
]
sourceSets { sourceSets {
main { main {
java { java {
@ -636,6 +649,10 @@ test {
exclude fragileTestPatterns exclude fragileTestPatterns
exclude outcastTestPatterns exclude outcastTestPatterns
if (rootProject.findProperty("skipDockerIncompatibleTests") == "true") {
exclude dockerIncompatibleTestPatterns
}
// Run every test class in its own process. // Run every test class in its own process.
// Uncomment to unblock build while troubleshooting inexplicable test errors. // Uncomment to unblock build while troubleshooting inexplicable test errors.
// This setting makes the build take 35 minutes, without it it takes about 10. // This setting makes the build take 35 minutes, without it it takes about 10.

View file

@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4-bin.zip distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-bin.zip
zipStoreBase=GRADLE_USER_HOME zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists zipStorePath=wrapper/dists

View file

@ -26,7 +26,7 @@ steps:
args: ['mkdir', 'nomulus'] args: ['mkdir', 'nomulus']
# Run tests # Run tests
- name: 'gcr.io/${PROJECT_ID}/builder:latest' - name: 'gcr.io/${PROJECT_ID}/builder:latest'
args: ['./gradlew', 'test'] args: ['./gradlew', 'test', '-PskipDockerIncompatibleTests=true']
dir: 'gradle' dir: 'gradle'
# Build and package the deployment files for alpha. # Build and package the deployment files for alpha.
- name: 'gcr.io/${PROJECT_ID}/builder:latest' - name: 'gcr.io/${PROJECT_ID}/builder:latest'