zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 00:47:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Delete unused description field from premium/reserved list entities

Browse source 
It isn't used now, and as far as I can tell it was never used for anything, so
get rid of it.  We won't be using it in our new Cloud SQL schema anyway.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=242501877
This commit is contained in:
mcilwain 2019-04-08 11:25:59 -07:00 • committed by jianglai
parent 1897b9d442
commit 1c33f38555
4 changed files with 3 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

7
java/google/registry/model/registry/label/BaseDomainLabelList.java
View file

@ -64,8 +64,6 @@ public abstract class BaseDomainLabelList<T extends Comparable<?>, R extends Dom
DateTime lastUpdateTime; DateTime lastUpdateTime;
String description;
public String getName() { public String getName() {
return name; return name;
} }
@ -182,11 +180,6 @@ public abstract class BaseDomainLabelList<T extends Comparable<?>, R extends Dom
return thisCastToDerived(); return thisCastToDerived();
} }
public B setDescription(String description) {
getInstance().description = description;
return thisCastToDerived();
}
@Override @Override
public T build() { public T build() {
checkArgument(!isNullOrEmpty(getInstance().name), "List must have a name"); checkArgument(!isNullOrEmpty(getInstance().name), "List must have a name");

1
javatests/google/registry/model/registry/label/ReservedListTest.java
View file

@ -332,7 +332,6 @@ public class ReservedListTest {
ReservedList clone = original.asBuilder().build(); ReservedList clone = original.asBuilder().build();
assertThat(clone.getName()).isEqualTo("tld-reserved-cloning"); assertThat(clone.getName()).isEqualTo("tld-reserved-cloning");
assertThat(clone.creationTime).isEqualTo(original.creationTime); assertThat(clone.creationTime).isEqualTo(original.creationTime);
assertThat(clone.description).isEqualTo(original.description);
assertThat(clone.lastUpdateTime).isEqualTo(original.lastUpdateTime); assertThat(clone.lastUpdateTime).isEqualTo(original.lastUpdateTime);
assertThat(clone.parent).isEqualTo(original.parent); assertThat(clone.parent).isEqualTo(original.parent);
assertThat(original.getReservedListEntries()).isEqualTo(clone.getReservedListEntries()); assertThat(original.getReservedListEntries()).isEqualTo(clone.getReservedListEntries());

2
javatests/google/registry/model/testdata/schema.txt vendored
View file

@ -525,7 +525,6 @@ class google.registry.model.registry.label.PremiumList {
@Id java.lang.String name; @Id java.lang.String name;
@Parent com.googlecode.objectify.Key<google.registry.model.common.EntityGroupRoot> parent; @Parent com.googlecode.objectify.Key<google.registry.model.common.EntityGroupRoot> parent;
com.googlecode.objectify.Key<google.registry.model.registry.label.PremiumList$PremiumListRevision> revisionKey; com.googlecode.objectify.Key<google.registry.model.registry.label.PremiumList$PremiumListRevision> revisionKey;
java.lang.String description;
org.joda.time.DateTime creationTime; org.joda.time.DateTime creationTime;
org.joda.time.DateTime lastUpdateTime; org.joda.time.DateTime lastUpdateTime;
} }
@ -552,7 +551,6 @@ class google.registry.model.registry.label.ReservedList {
@Id java.lang.String name; @Id java.lang.String name;
@Parent com.googlecode.objectify.Key<google.registry.model.common.EntityGroupRoot> parent; @Parent com.googlecode.objectify.Key<google.registry.model.common.EntityGroupRoot> parent;
boolean shouldPublish; boolean shouldPublish;
java.lang.String description;
java.util.Map<java.lang.String, google.registry.model.registry.label.ReservedList$ReservedListEntry> reservedListMap; java.util.Map<java.lang.String, google.registry.model.registry.label.ReservedList$ReservedListEntry> reservedListMap;
org.joda.time.DateTime creationTime; org.joda.time.DateTime creationTime;
org.joda.time.DateTime lastUpdateTime; org.joda.time.DateTime lastUpdateTime;

6
javatests/google/registry/tools/server/ListPremiumListsActionTest.java
View file

@ -52,11 +52,11 @@ public class ListPremiumListsActionTest extends ListActionTestCase {
public void testRun_withParameters() { public void testRun_withParameters() {
testRunSuccess( testRunSuccess(
action, action,
Optional.of("revisionKey,description"), Optional.of("revisionKey"),
Optional.empty(), Optional.empty(),
Optional.empty(), Optional.empty(),
"^name\\s+revisionKey\\s+description\\s*$", "^name\\s+revisionKey\\s*$",
"^-+\\s+-+\\s+-+\\s*$", "^-+\\s+-+\\s*$",
"^how\\s+.*PremiumList.*$", "^how\\s+.*PremiumList.*$",
"^xn--q9jyb4c\\s+.*PremiumList.*$"); "^xn--q9jyb4c\\s+.*PremiumList.*$");
} }