Refactor DnsWriter into the model package

This is one of several CLs in order to support per-TLD DnsWriter
implementations, modeled on the work done for PremiumPricingEngine.

Since DnsWriters will be set inside the Registry object, the DnsWriter
interface definition needs to be moved to models to create minimal
dependency on the rest of the registry codebase to avoid cyclic
dependency.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=128711643

java/google/registry/dns/BUILD

@@ -38,7 +38,6 @@ java_library(
         "//third_party/java/objectify:objectify-v4_1",
         "//third_party/java/servlet/servlet_api",
         "//java/google/registry/config",
-        "//java/google/registry/dns/writer/api",
         "//java/google/registry/model",
         "//java/google/registry/request",
         "//java/google/registry/util",

java/google/registry/dns/DnsModule.java

@@ -30,7 +30,7 @@ import dagger.Binds;
 import dagger.Module;
 import dagger.Provides;
 import google.registry.dns.DnsConstants.TargetType;
-import google.registry.dns.writer.api.DnsWriterZone;
+import google.registry.model.dns.DnsWriterZone;
 import google.registry.request.Parameter;
 import google.registry.request.RequestParameters;
 import java.util.Set;

java/google/registry/dns/PublishDnsUpdatesAction.java

@@ -20,7 +20,7 @@ import static google.registry.util.CollectionUtils.nullToEmpty;
 
 import com.google.common.net.InternetDomainName;
 import google.registry.config.ConfigModule.Config;
-import google.registry.dns.writer.api.DnsWriter;
+import google.registry.model.dns.DnsWriter;
 import google.registry.request.Action;
 import google.registry.request.HttpException.ServiceUnavailableException;
 import google.registry.request.Parameter;

java/google/registry/dns/writer/BUILD

@@ -6,13 +6,13 @@ licenses(["notice"])  # Apache 2.0
 
 
 java_library(
-    name = "api",
+    name = "writer",
     srcs = glob(["*.java"]),
-    compatible_with = ["//buildenv/target:appengine"],
     deps = [
         "//java/com/google/common/base",
         "//third_party/java/dagger",
         "//third_party/java/jsr305_annotations",
         "//third_party/java/jsr330_inject",
+        "//java/google/registry/model",
     ],
 )

java/google/registry/dns/writer/VoidDnsWriter.java

@@ -12,9 +12,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package google.registry.dns.writer.api;
+package google.registry.dns.writer;
 
 import com.google.common.base.Joiner;
+import google.registry.model.dns.DnsWriter;
 import java.util.HashSet;
 import java.util.Set;
 import java.util.logging.Logger;

java/google/registry/dns/writer/VoidDnsWriterModule.java

@@ -12,10 +12,11 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package google.registry.dns.writer.api;
+package google.registry.dns.writer;
 
 import dagger.Module;
 import dagger.Provides;
+import google.registry.model.dns.DnsWriter;
 
 /** Dagger module that disables DNS updates. */
 @Module

java/google/registry/dns/writer/dnsupdate/BUILD

@@ -21,7 +21,6 @@ java_library(
         "//third_party/java/jsr305_annotations",
         "//third_party/java/jsr330_inject",
         "//java/google/registry/config",
-        "//java/google/registry/dns/writer/api",
         "//java/google/registry/model",
         "//java/google/registry/util",
     ],

java/google/registry/dns/writer/dnsupdate/DnsUpdateWriter.java

@@ -19,7 +19,7 @@ import static google.registry.model.EppResourceUtils.loadByUniqueId;
 
 import com.google.common.net.InternetDomainName;
 import google.registry.config.ConfigModule.Config;
-import google.registry.dns.writer.api.DnsWriter;
+import google.registry.model.dns.DnsWriter;
 import google.registry.model.domain.DomainResource;
 import google.registry.model.domain.secdns.DelegationSignerData;
 import google.registry.model.host.HostResource;

java/google/registry/dns/writer/dnsupdate/DnsUpdateWriterModule.java

@@ -17,7 +17,7 @@ package google.registry.dns.writer.dnsupdate;
 import dagger.Binds;
 import dagger.Module;
 import dagger.Provides;
-import google.registry.dns.writer.api.DnsWriter;
+import google.registry.model.dns.DnsWriter;
 import javax.net.SocketFactory;
 
 /** Dagger module that provides a DnsUpdateWriter. */

java/google/registry/model/dns/DnsWriter.java

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package google.registry.dns.writer.api;
+package google.registry.model.dns;
 
 /**
  * Transaction object for sending an atomic batch of updates for a single zone to the DNS server.

java/google/registry/model/dns/DnsWriterZone.java

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package google.registry.dns.writer.api;
+package google.registry.model.dns;
 
 import java.lang.annotation.Documented;
 import javax.inject.Qualifier;

java/google/registry/module/backend/BUILD

@@ -19,7 +19,7 @@ java_library(
         "//java/google/registry/config",
         "//java/google/registry/cron",
         "//java/google/registry/dns",
-        "//java/google/registry/dns/writer/api",
+        "//java/google/registry/dns/writer",
         "//java/google/registry/export",
         "//java/google/registry/export/sheet",
         "//java/google/registry/flows",

java/google/registry/module/backend/BackendComponent.java

@@ -17,7 +17,7 @@ package google.registry.module.backend;
 import dagger.Component;
 import google.registry.bigquery.BigqueryModule;
 import google.registry.config.ConfigModule;
-import google.registry.dns.writer.api.VoidDnsWriterModule;
+import google.registry.dns.writer.VoidDnsWriterModule;
 import google.registry.export.DriveModule;
 import google.registry.export.sheet.SpreadsheetServiceModule;
 import google.registry.gcs.GcsServiceModule;

javatests/google/registry/dns/BUILD

@@ -32,7 +32,7 @@ java_library(
         "//java/google/registry/cron",
         "//java/google/registry/dns",
         "//java/google/registry/dns:constants",
-        "//java/google/registry/dns/writer/api",
+        "//java/google/registry/dns/writer",
         "//java/google/registry/model",
         "//java/google/registry/module/backend",
         "//java/google/registry/request",

javatests/google/registry/dns/DnsTestComponent.java

@@ -17,7 +17,7 @@ package google.registry.dns;
 import dagger.Component;
 import google.registry.config.ConfigModule;
 import google.registry.cron.CronModule;
-import google.registry.dns.writer.api.VoidDnsWriterModule;
+import google.registry.dns.writer.VoidDnsWriterModule;
 import google.registry.module.backend.BackendModule;
 import google.registry.request.RequestModule;
 import google.registry.util.SystemClock.SystemClockModule;

javatests/google/registry/dns/PublishDnsUpdatesActionTest.java

@@ -22,7 +22,7 @@ import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
 
 import com.google.common.collect.ImmutableSet;
-import google.registry.dns.writer.api.DnsWriter;
+import google.registry.model.dns.DnsWriter;
 import google.registry.model.domain.DomainResource;
 import google.registry.model.ofy.Ofy;
 import google.registry.testing.AppEngineRule;