zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 17:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Mark nullable parameters as nullable

Browse source 
A few nullable parameters were not marked as nullable, which causes exceptions
to be thrown in debug mode.

This had no effect in the deployed web server, because these assert sanity
checks aren't performed - but on our local test server this failed.

Note that all these fields are checked for "nullness" in the code itself. It's
just an oversight in the declaration.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=226187227
This commit is contained in:
guyben 2018-12-19 09:43:26 -08:00 • committed by Michael Muller
parent 51f22a15ed
commit 1975218f45
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
java/google/registry/ui/soy/registrar/SecuritySettings.soy
View file

@ -18,7 +18,7 @@
/** Registrar security settings page for view and edit. */ /** Registrar security settings page for view and edit. */
{template .settings} {template .settings}
{@param ipAddressWhitelist: list<string>} {@param ipAddressWhitelist: list<string>}
{@param phonePasscode: string} {@param? phonePasscode: string}
{@param? clientCertificate: string} {@param? clientCertificate: string}
{@param? clientCertificateHash: string} {@param? clientCertificateHash: string}
{@param? failoverClientCertificate: string} {@param? failoverClientCertificate: string}

4
java/google/registry/ui/soy/registrar/WhoisSettings.soy
View file

@ -19,8 +19,8 @@
/** Registrar whois settings page for view and edit. */ /** Registrar whois settings page for view and edit. */
{template .settings} {template .settings}
{@param clientIdentifier: string} {@param clientIdentifier: string}
{@param ianaIdentifier: int} {@param? ianaIdentifier: int}
{@param icannReferralEmail: string} {@param? icannReferralEmail: string}
{@param readonly: bool} {@param readonly: bool}
{@param? whoisServer: string} {@param? whoisServer: string}
{@param? url: string} {@param? url: string}