From 15ba52988b230720026c55fa319a8c82dced98c2 Mon Sep 17 00:00:00 2001 From: cgoldfeder Date: Tue, 24 Jan 2017 08:38:26 -0800 Subject: [PATCH] Remove LINKED from the disallowed statuses for contact/host delete LINKED is supposed to be a virtual status that gets added/removed when needed. It's mistakenly been persisted to datastore on many resources, but the persisted value is meaningless and may not represent reality at all. There is no reason to check for LINKED status before kicking off a delete, since the smoke test and [] will catch all actual linked objects, and the LINKED status can be causing false positives for objects that are no longer LINKED. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145422457 --- java/google/registry/flows/contact/ContactDeleteFlow.java | 1 - java/google/registry/flows/host/HostDeleteFlow.java | 1 - 2 files changed, 2 deletions(-) diff --git a/java/google/registry/flows/contact/ContactDeleteFlow.java b/java/google/registry/flows/contact/ContactDeleteFlow.java index 794177b7e..f183cb870 100644 --- a/java/google/registry/flows/contact/ContactDeleteFlow.java +++ b/java/google/registry/flows/contact/ContactDeleteFlow.java @@ -61,7 +61,6 @@ import org.joda.time.DateTime; public final class ContactDeleteFlow implements TransactionalFlow { private static final ImmutableSet DISALLOWED_STATUSES = ImmutableSet.of( - StatusValue.LINKED, StatusValue.CLIENT_DELETE_PROHIBITED, StatusValue.PENDING_DELETE, StatusValue.SERVER_DELETE_PROHIBITED); diff --git a/java/google/registry/flows/host/HostDeleteFlow.java b/java/google/registry/flows/host/HostDeleteFlow.java index e490b956b..66bbeabd0 100644 --- a/java/google/registry/flows/host/HostDeleteFlow.java +++ b/java/google/registry/flows/host/HostDeleteFlow.java @@ -62,7 +62,6 @@ import org.joda.time.DateTime; public final class HostDeleteFlow implements TransactionalFlow { private static final ImmutableSet DISALLOWED_STATUSES = ImmutableSet.of( - StatusValue.LINKED, StatusValue.CLIENT_DELETE_PROHIBITED, StatusValue.PENDING_DELETE, StatusValue.SERVER_DELETE_PROHIBITED);