zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix NPE in GetHistoryEntriesCommand

Browse source 
The code was not checking the value returned by getTrid() to make sure it was
not null.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172384499
This commit is contained in:
mountford 2017-05-07 15:06:14 -04:00 • committed by jianglai
parent 07240162a2
commit 108deb7f9d
3 changed files with 90 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
java/google/registry/tools/GetHistoryEntriesCommand.java
View file

@ -77,8 +77,8 @@ final class GetHistoryEntriesCommand implements RemoteApiCommand {
"Client: %s\nTime: %s\nClient TRID: %s\nServer TRID: %s\n%s\n",
entry.getClientId(),
entry.getModificationTime(),
entry.getTrid().getClientTransactionId(),
entry.getTrid().getServerTransactionId(),
(entry.getTrid() == null) ? null : entry.getTrid().getClientTransactionId(),
(entry.getTrid() == null) ? null : entry.getTrid().getServerTransactionId(),
entry.getXmlBytes() == null
? String.format("[no XML stored for %s]\n", entry.getType())
: XmlTransformer.prettyPrint(entry.getXmlBytes()));