zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 00:47:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

RDAP: Remove port43 element from JSON output

Browse source 
According to Gustavo Lozano of ICANN: "In the case of the RDAP profile (gTLD space), the “port43” element is not expected to be used, because Whois/43 tcp will be deprecated in the future." So it sounds like we should not include the port43 element for the moment.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=130017966
This commit is contained in:
mountford 2016-08-11 12:23:39 -07:00 • committed by Ben McIlwain
parent 72894253ae
commit 0cab13e6d8
32 changed files with 43 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

10
java/google/registry/config/ConfigModule.java
View file

@ -23,6 +23,7 @@ import dagger.Provides;
import java.lang.annotation.Documented;
import java.net.URI;
import java.net.URL;
import javax.annotation.Nullable;
import javax.inject.Qualifier;
import org.joda.money.CurrencyUnit;
import org.joda.time.DateTimeConstants;
@ -319,7 +320,7 @@ public final class ConfigModule {
*/
@Provides
@Config("rdeImportBucket")
public String provideRdeImportBucket(@Config("projectId") String projectId) {
public static String provideRdeImportBucket(@Config("projectId") String projectId) {
return projectId + "-rde-import";
}
@ -533,14 +534,17 @@ public final class ConfigModule {
}
/**
* WHOIS server displayed in RDAP query responses.
* WHOIS server displayed in RDAP query responses. As per Gustavo Lozano of ICANN, this should be
* omitted, but the ICANN operational profile doesn't actually say that, so it's good to have the
* ability to reinstate this field if necessary.
*
* @see google.registry.rdap.RdapActionBase
*/
@Nullable
@Provides
@Config("rdapWhoisServer")
public static String provideRdapWhoisServer() {
return "whois.nic.google";
return null;
}
/** Returns Braintree Merchant Account IDs for each supported currency. */